code_block: Fix null-check ! errors during hot reloads
#789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
added
the
a-content
On hot-reload, `lerp` is triggered even when the theme has not changed. Discussion: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/Exceptions.20during.20hot.20reloads/near/1846095 I considered just going ahead with placing the web app's current light-theme styles for code blocks (zulip#754), but pretty soon I realized there would still be some nulls in there after doing so, and those would need to be treated like we're treating the nulls here.
|
Thanks! Looks good; merging. |
gnprice
force-pushed
the
pr-fix-code-block-nulls-error
branch
from
f5f0da8 to
74de34c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On hot-reload,
lerpis triggered even when the theme has not changed. Discussion:https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/Exceptions.20during.20hot.20reloads/near/1846095
I considered just going ahead with placing the web app's current light-theme styles for code blocks (#754), but pretty soon I realized there would still be some nulls in there after doing so, and those would need to be treated like we're treating the nulls here.