test [nfc]: Ensure user IDs, message IDs, etc. are positive #877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zulip message IDs and stream/channel IDs, like user IDs, are positive integers. So avoiding zero for them helps keep the test data realistic.
Our account IDs are always positive integers, because they're generated by inserting into an AUTOINCREMENT column in our SQLite database: https://www.sqlite.org/autoinc.html So avoiding zero here helps keep the data realistic.
Unlike the various IDs for things in the database (users, messages, etc.), which are always positive, Zulip event IDs start at zero. Correspondingly, InitialSnapshot.lastEventId is -1 if there were no events queued up concurrently with the initial snapshot getting generated. So in the spirit of maximum boringness for test data, use those values by default.
|
LGTM, thank you! |
PIG208
reviewed
Aug 12, 2024
| apiKey: 'user${i}apikey', | ||
| )); | ||
| return List.generate(count, (i) { | ||
| final id = i+1; |
There was a problem hiding this comment.
nit:
Suggested change
| final id = i+1; | |
| final id = i + 1; |
There was a problem hiding this comment.
Ah indeed, thanks.
An expression like "x+1" is something I'm pretty happy with being formatted either way — that or x + 1. So we can just leave it be.
If at some point in the future dartfmt gains the needed flexibility for Flutter upstream to adopt it and we follow, then it'll presumably turn this to i + 1 and that'll be fine too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zulip user IDs, message IDs, and stream/channel IDs (and anything else that's an ID of a row in the server database) are positive integers. So are our account IDs. To help keep test data realistic, enforce those in the example-data functions.
This follows up on 739fa84 (in #828; /cc @sm-sayedi), which made a similar fix for one test case.