Skip to content

deps: Upgrade Flutter to 3.25.0-1.0.pre.41 #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2024
Merged

deps: Upgrade Flutter to 3.25.0-1.0.pre.41 #899

merged 3 commits into from
Aug 21, 2024

Conversation

PIG208
Copy link
Member

@PIG208 PIG208 commented Aug 20, 2024

And update Flutter's supporting libraries to match.

@PIG208 PIG208 requested a review from chrisbobbe August 20, 2024 21:49
@PIG208 PIG208 added the maintainer review PR ready for review by Zulip maintainers label Aug 20, 2024
@rajveermalviya
Copy link
Member

I just tested with the latest Flutter main, and I'm happy to report that (on my device) animations and transitions are smooth again, with no rendering artifacts on the Impeller rendering backend. It seems those issues have been fixed in this update, though not sure which commits addressed them.

PIG208 and others added 3 commits August 21, 2024 13:04
And update Flutter's supporting libraries to match.
The `tools/check` run is largely redundant with Flutter upstream's CI,
which will have run our `flutter analyze` and `flutter test` before
allowing any given upstream change to be merged.  If something gets
past that (perhaps because it affects some other suite like
re-generating our generated files), our own CI will catch it.
We don't plan to switch to "beta" or "stable" versions -- better to
live at head, by sticking to the main channel.

(We still want to pin the precise version, but let the issue track
that.  The pubspec here isn't what would control a pin anyway.)

Also point to our instructions for upgrading these versions.
@gnprice
Copy link
Member

gnprice commented Aug 21, 2024

Thanks @PIG208, and thanks @rajveermalviya for that testing! Glad to hear they've fixed those Impeller issues.

Merging. I revised the README change and added an update to the pubspec.yaml comment.

@gnprice gnprice merged commit 67f8429 into zulip:main Aug 21, 2024
1 check passed
@PIG208 PIG208 deleted the deps branch August 21, 2024 20:06
gnprice added a commit that referenced this pull request Oct 10, 2024
We plan to continue to live at head, using the Flutter main channel,
in the future when the app is out of beta.  Update the README to
reflect that.

See 67f8429 (#899) which made a similar change in the comment
in pubspec.yaml.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer review PR ready for review by Zulip maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants