Skip to content

deps: Add some overrides to unblock Flutter Color API changes for wide-gamut #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -199,12 +199,13 @@ packages:
source: hosted
version: "1.19.0"
color_models:
dependency: transitive
dependency: "direct overridden"
description:
name: color_models
sha256: "3683f0a461570161ca22b7d3e1765b2ce2bce3534db14e00d5ee458d0287abac"
url: "https://pub.dev"
source: hosted
path: color_models
ref: wide-gamut
resolved-ref: "27298bc2cbfc9f1da08503be68da472076bcb61c"
url: "https://github.com/gaaclarke/color_models.git"
source: git
version: "1.3.3"
convert:
dependency: "direct main"
Expand Down Expand Up @@ -422,11 +423,12 @@ packages:
flutter_color_models:
dependency: "direct main"
description:
name: flutter_color_models
sha256: "8454198ba9a82e533452d0764f1df3d6c3ccc2b33e18eb1f2fedc7ae4a5c43be"
url: "https://pub.dev"
source: hosted
version: "1.3.3+2"
path: flutter_color_models
ref: wide-gamut
resolved-ref: "27298bc2cbfc9f1da08503be68da472076bcb61c"
url: "https://github.com/gaaclarke/color_models.git"
source: git
version: "1.4.0"
flutter_driver:
dependency: "direct dev"
description: flutter
Expand Down
16 changes: 16 additions & 0 deletions pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,22 @@ dependencies:
path: ./packages/zulip_plugin
# Keep list sorted when adding dependencies; it helps prevent merge conflicts.

dependency_overrides:
# TODO(#918) remove this and `flutter_color_models` when `flutter_color_models` accommodates
# wide-gamut adjustments to Flutter's `Color`. A PR to `flutter_color_models` is already open:
# https://github.com/james-alex/color_models/pull/10
color_models:
git:
url: https://github.com/gaaclarke/color_models.git
ref: wide-gamut
path: color_models
flutter_color_models:
git:
url: https://github.com/gaaclarke/color_models.git
ref: wide-gamut
path: flutter_color_models


dev_dependencies:
flutter_driver:
sdk: flutter
Expand Down