Skip to content

deps: Upgrade video_player_android to 2.7.3 #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

rajveermalviya
Copy link
Member

@rajveermalviya rajveermalviya commented Sep 18, 2024

Changelog:
https://pub.dev/packages/video_player_android/changelog

This update migrates the plugin to use newer API recommended
to support Impeller:
https://docs.flutter.dev/release/breaking-changes/android-surface-plugins

Without this migration, the videos do play but they look
pixelated, resulting in a bad UX.

before after
before after

Additionally, it updates the underlying Media3-ExoPlayer
library to version 1.4.1:
https://developer.android.com/jetpack/androidx/releases/media3#1.4.1

@rajveermalviya rajveermalviya added the maintainer review PR ready for review by Zulip maintainers label Sep 18, 2024
@chrisbobbe
Copy link
Collaborator

Sure, LGTM, thanks! Marking for Greg's review.

@chrisbobbe chrisbobbe added integration review Added by maintainers when PR may be ready for integration and removed maintainer review PR ready for review by Zulip maintainers labels Sep 18, 2024
@chrisbobbe chrisbobbe requested a review from gnprice September 18, 2024 19:19
@gnprice
Copy link
Member

gnprice commented Sep 20, 2024

Thanks! Looks good — merging.

Additionally, it updates the underlying Media3-ExoPlayer
library to version 1.4.1:
https://developer.android.com/jetpack/androidx/releases/media3#1.4.1

Was the previous version 1.4.0, or something else? That's always important information for being able to interpret a changelog like that 🙂

(Not blocking the merge on that, because knowing those details probably won't end up being relevant, and if it does then we can always do the archeology then.)

Changelog:
  https://pub.dev/packages/video_player_android/changelog

This update migrates the plugin to use newer API recommended
to support Impeller:
  https://docs.flutter.dev/release/breaking-changes/android-surface-plugins

Without this migration, the videos do play but they look
pixelated, resulting in a bad UX.

Additionally updates the underlying Media3-ExoPlayer
library to version 1.4.1:
  https://developer.android.com/jetpack/androidx/releases/media3#1.4.1
@gnprice gnprice force-pushed the pr-fix-video-player branch from da2b527 to ea8c765 Compare September 20, 2024 22:34
@gnprice gnprice merged commit ea8c765 into zulip:main Sep 20, 2024
1 check passed
@rajveermalviya rajveermalviya deleted the pr-fix-video-player branch September 23, 2024 15:50
@rajveermalviya
Copy link
Member Author

Was the previous version 1.4.0

Correct, previously it was 1.4.0 (flutter/packages@a6db33c; Side note: The squash merge of the Dependabot PR uses the PR description as the commit message, which results in an ugly commit message. The actual commit message can be found here.)

That's always important information for being able to interpret a changelog like that 🙂

(Not blocking the merge on that,

Thanks, I'll keep that in mind!

@gnprice
Copy link
Member

gnprice commented Sep 24, 2024

The squash merge of the Dependabot PR uses the PR description as the commit message, which results in an ugly commit message.

Wow, yep. Good that Dependabot provides something more readable in its original commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants