deps: Upgrade video_player_android to 2.7.8 #983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajveermalviya
added
the
maintainer review
chrisbobbe
approved these changes
Oct 5, 2024
chrisbobbe
added
integration review
Changelog: https://pub.dev/packages/video_player_android/changelog This update addresses a few bug fixes, including the removal of a flag that treats warnings as errors. Without this fix, Android builds fail in Android Studio 2024.2, which uses Java 21, with the following error: warning: [options] source value 8 is obsolete and will be removed in a future release warning: [options] target value 8 is obsolete and will be removed in a future release warning: [options] To suppress warnings about obsolete options, use -Xlint:-options. error: warnings found and -Werror specified With this update the warnings still stay, but are ignored by build system resulting in a successful build. [Greg adds: the changelog shows one potentially user-facing bug fix, when reopening the app from the background while a video was playing; but I couldn't reproduce that issue in our app.]
|
Thanks! Looks good; merging. From the package's changelog, it looks like there's one potentially user-facing bug this fixes: I couldn't reproduce that in our app on a quick attempt, though, so it might not affect us for some reason. Anyway, added a quick note about it to the commit message. |
gnprice
force-pushed
the
pr-java-21-fix
branch
from
8b3b856 to
a435083
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
https://pub.dev/packages/video_player_android/changelog
This update addresses a few bug fixes, including the removal of a flag that treats warnings as errors. Without this fix, Android builds fail in Android Studio 2024.2, which uses Java 21, with the following error:
With this update the warnings still stay, but are ignored by build system resulting in a successful build.