DOCSP-47044: Polling DNS SRV records #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mongoKart
requested changes
Mar 3, 2025
dbx/srv-polling.rst
Outdated
| @@ -0,0 +1,11 @@ | |||
| To use DNS service discovery to look up the DNS SRV record of the service you're connecting to, | |||
| specify the SRV connection format in your connection string. Additionally, if you enable | |||
| the SRV connection format, the {+driver-short+} automatically re-scans for new hosts without | |||
There was a problem hiding this comment.
Suggested change
| the SRV connection format, the {+driver-short+} automatically re-scans for new hosts without | |
| the SRV connection format, the {+driver-short+} automatically rescans for new hosts without |
dbx/srv-polling.rst
Outdated
Comment on lines
2
to
3
| specify the SRV connection format in your connection string. Additionally, if you enable | ||
| the SRV connection format, the {+driver-short+} automatically re-scans for new hosts without |
There was a problem hiding this comment.
s:
Suggested change
| specify the SRV connection format in your connection string. Additionally, if you enable | |
| the SRV connection format, the {+driver-short+} automatically re-scans for new hosts without | |
| specify the SRV connection format in your connection string. If you specify | |
| this format, the {+driver-short+} automatically re-scans for new hosts without |
dbx/srv-polling.rst
Outdated
Comment on lines
3
to
4
| the SRV connection format, the {+driver-short+} automatically re-scans for new hosts without | ||
| having to change the client configuration. |
There was a problem hiding this comment.
this syntax is a little odd. it makes it sound like the driver (subject of the sentence) is the thing that has to or doesn't have to change the config, even though it's the user who does that. what if we just ditch the last part?
Suggested change
| the SRV connection format, the {+driver-short+} automatically re-scans for new hosts without | |
| having to change the client configuration. | |
| the SRV connection format, the {+driver-short+} automatically re-scans for new hosts. |
There was a problem hiding this comment.
I added an extra sentence that's hopefully more clear, let me know what you think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA - https://jira.mongodb.org/browse/DOCSP-47044
Copied from the PyMongo section on DNS SRV records