Skip to content

DOCSP-46697: SRV record section #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 27, 2025
Merged

DOCSP-46697: SRV record section #186

merged 3 commits into from
Feb 27, 2025

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Feb 25, 2025 •
edited
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-46697

Staging Links

  • connect/connection-targets

    • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    @netlify Netlify
    Copy link

    netlify bot commented Feb 25, 2025 •
    edited
    Loading

    ✅ Deploy Preview for docs-pymongo ready!

    Name Link
    🔨 Latest commit ec6148e
    🔍 Latest deploy log https://app.netlify.com/sites/docs-pymongo/deploys/67bf309ca0fab8000864c919
    😎 Deploy Preview https://deploy-preview-186--docs-pymongo.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    norareidy
    norareidy requested changes Feb 25, 2025
    View reviewed changes
    Copy link
    Collaborator

    @norareidy norareidy left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Left a suggestion about adding more information about polling, so I'll take another look!

    @mcmorisi mcmorisi requested a review from norareidy February 26, 2025 17:44
    norareidy
    norareidy approved these changes Feb 27, 2025
    View reviewed changes
    Copy link
    Collaborator

    @norareidy norareidy left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM!

    @mcmorisi mcmorisi requested a review from NoahStapp February 27, 2025 15:20
    @mcmorisi mcmorisi merged commit 894e587 into mongodb:master Feb 27, 2025
    6 checks passed
    @mcmorisi mcmorisi deleted the DOCSP-46697-srv-records branch February 27, 2025 17:08
    mcmorisi added a commit that referenced this pull request Feb 27, 2025
    @mcmorisi
    DOCSP-46697: SRV record section (#186)
    8fb024a 
    (cherry picked from commit 894e587)
    mcmorisi added a commit that referenced this pull request Feb 27, 2025
    @mcmorisi
    DOCSP-46697: SRV record section (#186)
    e75d822 
    (cherry picked from commit 894e587)
    mcmorisi added a commit that referenced this pull request Feb 27, 2025
    @mcmorisi
    DOCSP-46697: SRV record section (#186)
    92b8eff 
    (cherry picked from commit 894e587)
    mcmorisi added a commit that referenced this pull request Feb 27, 2025
    @mcmorisi
    DOCSP-46697: SRV record section (#186)
    ace3f57 
    (cherry picked from commit 894e587)
    mcmorisi added a commit that referenced this pull request Feb 27, 2025
    @mcmorisi
    DOCSP-46697: SRV record section (#186)
    3d7a6f8 
    (cherry picked from commit 894e587)
    @norareidy norareidy mentioned this pull request Mar 3, 2025
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @NoahStapp NoahStapp NoahStapp approved these changes

    @norareidy norareidy norareidy approved these changes

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @mcmorisi @NoahStapp @norareidy