-
Notifications
You must be signed in to change notification settings - Fork 179
Supported lists #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supported lists #460
Conversation
1b21489
to
52990dc
Compare
Might be worth noting that this will probably fail with an error with mbed OS releases that didn't have the capability added in ARMmbed/mbed-os#3993. Should we be handling this error in this case (might not be necessary)? |
I'm not sure, @screamerbg what do you think? |
@mbartling @bridadan I agree about backwards compatibility issue. This PR should follow after ARMmbed/mbed-os#3993 becomes mainline and widely used. |
FYI ARMmbed/mbed-os#3993 is now merged |
@mbartling Can you rebase please? |
52990dc
to
48d9708
Compare
@mbartling Do you feel this is ready to go in? |
It's been a few months, do you think this has been main streamed in mbed-os? |
I think this should be ready to merge |
@theotherjimmy please review. |
@screamerbg After the rebase, I'll review. @mbartling Could you ping me after the rebase is done so that I can review? |
48d9708
to
02348ce
Compare
@theotherjimmy rebase is complete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Added ability to list toolchains, ides, targets in addition to the supported matrix output. Solves #306.
NOTE: This depends on ARMmbed/mbed-os#3993. @screamerbg @theotherjimmy can you guys think of a workaround? Should I just add a try catch?