-
Notifications
You must be signed in to change notification settings - Fork 179
Restored mbed target --supported
behavior
#572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The underlying problem is the introduction of the This PR doesn't fix it (rather makes it worse). Appropriate fix should revert the
|
@cmonr @screamerbg We may be able to solve this by passing nothing when the argument to |
@screamerbg Could you advise us on how to add a test that verifies that we do this in a backwards compatible way? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmonr could you change this PR so it removes "matrix" as a default argument passed to the underlying OS tools? Then align what's being passed through either mbed compile -S
and mbed target -S
. Does this make sense?
@cmonr Regarding how to test supported, perhaps check the circleCI file, and after |
@theotherjimmy Perhaps the same test can be invoked for |
@screamerbg Well that's amusing. Regarding how to test, that's effectively what I'm doing right now, except I sped it up by having separate directories checked out to their appropriate versions. |
@cmonr No pretty but it would do the job. You can make it look neat if you iterate through |
@screamerbg Any particular reason why |
Performed manual tests on mbed-os-5.x.0 repos.
Don't merge yet until tests are written (tomorrow). Tested using Looking for guidance from @mbartling on how to test for his features. |
@cmonr if I'm not mistaken, one of the very first versions of mbed OS had the exporters broken in the x.0 release. |
@cmonr Any update on this? |
@screamerbg The tests have been added in. I didn't find any issues with exporting from 5.1.0 and up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @cmonr
Issue reference: #557