Update CircleCI to run parallel Python jobs #668
Conversation
| steps: | ||
| - run: sudo add-apt-repository -y ppa:terry.guo/gcc-arm-embedded | ||
| - run: sudo apt-get -y update | ||
| - run: sudo apt-get -y install gcc-arm-none-eabi=4.9.3.2015q3-1trusty1 |
There was a problem hiding this comment.
Can we update this to GCC 6.x? Pretty sure Mbed OS doesn't recommend using 4.9.x anymore.
There was a problem hiding this comment.
Woah. You're right, but I'd prefer to change only what's needed for the topic at hand.
Definitely going to need to submit another PR to get that updated.
There was a problem hiding this comment.
Updating GCC 6.x would only work for newer Mbed OS, but older cases will fail (like Morpheus). And the Morpheus routine is used for comprehensive multi-level dependencies handling, including removal of libraries etc.
There was a problem hiding this comment.
That make sense, but we should be testing with the recommended toolchain for each Mbed OS release. So if that means installing two different versions of GCC then we may need to do that.
| mbed compile -S | ||
| mbed toolchain -S | ||
| mbed target -S | ||
| mbed export -S |
There was a problem hiding this comment.
Instead of copy and pasting these commands, can the common ones be extracted to either a script or circleci job?
There was a problem hiding this comment.
Indeed. I also think there should be one test per feature release of mbed-os, but that was out of scope for this PR.
.circleci/config.yml
Outdated
| - run: mkdir .tests | ||
| - run: cd .tests && mbed new new-test | ||
| - run: |- | ||
| cd .tests/new-test/mbed-os | ||
| git fetch origin refs/pull/6886/head:pr6886 |
There was a problem hiding this comment.
Fyi: There was one last issue in mbed-os that this testing revealed, and is fixed with ARMmbed/mbed-os#6886.
Once that PR is in, these two lines will need to be updated to origin/master until 5.9.0 is released to make sure the updates are pulled in correctly.
|
Forgot that this PR doesn't have the mbed-cli py3 fixes. This is how far the CircleCI script gets with py3 before failing, assuming this PR and #667 are merged together: https://circleci.com/gh/cmonr/mbed-cli/157 The problem appears to be with https://os.mbed.com/teams/Morpheus/code/mbed-os/ when running the hg tests. Afaik, this won't be fixed until an mbed-os release is made. I could use some help in seeing if this can be worked around, similar to the line 118 workaround for git. |
|
@cmonr I think the problem is that https://os.mbed.com/teams/Morpheus/code/mbed-os/ is using an extremely out of date version of Mbed OS. In fact, that version was never actually released officially. Sounds like we just need to switch up the example to something wayyy more more recent. I'd suggest just using something like blinky or another maintained example. |
|
@cmonr It's fine if we continue to check the Python 2 cases and that the Python 3 use only Mbed OS 5.9 and above. |
- Uses version 2 of CircleCI yaml - Capabile of running python jobs in parallel - Removes version check from setup.py
Checkout will be removed once 5.9 is released.
setup.py
Outdated
| @@ -32,5 +32,5 @@ | |||
| 'mbed-cli=mbed.mbed:main', | |||
| ] | |||
| }, | |||
| python_requires='>=2.7.10, <3', | |||
| python_requires='>=2.7.10', | |||
There was a problem hiding this comment.
Perhaps this change should come with the other PR.
There was a problem hiding this comment.
Agreed. Will revert this.
| @@ -0,0 +1,145 @@ | |||
| version: 2 | |||
There was a problem hiding this comment.
Could you please update the circle_tests.py script which allows to run all commands from the circle.yml file and emulate circle CI test run?
There was a problem hiding this comment.
Now works across both versions!
|
@bridadan @screamerbg @theotherjimmy Mind rereviewing? |
|
Looks great! |
Replaces circle.yml with new CircleCI format.
py3 test is disabled until #667 comes in.
Updated config format to version 2.