Enabl-able Python 3 tools testing in Travis CI #6433

cmonr · 2018-03-22T20:00:13Z

Description

Updates Travis CI such that once mbed-cli 1.7.0 is released, automatic tools testing against Python 3 can be switched on with a single, small PR.

Tested in personal instance of Travis CI. When enabled, Python 3 fails appropriately. An aborted example can be found here: https://travis-ci.org/cmonr/mbed-os/builds/357062171.

Pull request type

[ ] Fix  
[ ] Refactor  
[ ] New target  
[X] Feature  
[ ] Breaking change

theotherjimmy · 2018-03-22T20:15:58Z

@cmonr Don't delete the dashes. it kills the check boxes.

theotherjimmy

Looks fine to me.

cmonr · 2018-03-22T20:20:57Z

@theotherjimmy Not sure I follow. Which dashes do you mean?

Doing a visual diff in Travis of this PR's branch and mbed-os master, they still look the same.

geky · 2018-03-23T08:29:57Z

.travis.yml

+#
+#    - <<: *tools-pytest
+#      env: NAME=tools-py3.6
+#      python: 3.6


nice!

why not turn it on?

Ignore me, I didn't read your message close enough 👍

Let's keep this pr open until python 3 support works again. Maybe we should create a branch for python3 work?

@geky Hmm, a feature branch might not be that bad of an idea, although I'm not confident it's needed. We actually already have some tools in master that are python3 ready, courtesy of @theotherjimmy.

I'd prefer to not keep PRs open as a progress indicator, mainly because I don't like to see PRs linger :)

@0xc0170 thoughts?

A branch will quickly become out of date with master and then be rebase hell, I think.

Fair enough

It just seems strange to merge something that is entirely commented out

That's fair. The flip side is that devs can enable the functionality to test porting efforts :)

0xc0170 · 2018-03-23T09:57:33Z

/morph build

mbed-ci · 2018-03-23T10:27:24Z

Build : SUCCESS

Build number : 1537
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6433/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-03-23T13:15:43Z

Exporter Build : SUCCESS

Build number : 1178
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6433/

mbed-ci · 2018-03-23T13:32:15Z

Test : SUCCESS

Build number : 1318
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6433/1318

theotherjimmy · 2018-03-23T15:15:39Z

@cmonr I was referring to the -s before the [ ] in the PR description.

cmonr · 2018-03-26T19:24:40Z

Parking for now. Will update and uncomment py3 sections when support is complete.

Will be enabled when tool support has been completely ported

cmonr · 2018-05-23T00:28:40Z

@theotherjimmy @geky @0xc0170 It's baaack!

This is the final piece to the puzzle. mbed-cli currently has two PRs open and should be merged and released within the week (ARMmbed/mbed-cli#668 and ARMmbed/mbed-cli#667).

What I suggest:
We get this PR tested and merged into 5.9.0-rc1, with a separate PR enabling py3 tests and updating the requirements.txt version to the updated version.

Thoughts?

li-ho · 2018-05-23T00:56:39Z

@cmonr, @theotherjimmy said add dashes in front of the following 5 lines of Pull request type
[ ] Fix
[ ] Refactor
[ ] New target
[X] Feature
[ ] Breaking change

and then produce

No code changes or testing are required.

mbed-ci · 2018-05-23T08:24:24Z

Build : SUCCESS

Build number : 2119
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6433/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-05-23T09:31:27Z

Exporter Build : SUCCESS

Build number : 1743
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6433/

cmonr · 2018-05-23T19:20:46Z

Halting the auto-started export and test builds, and will hold until review had been completed.

Build needs to be restarted anyways since the status wasn't captured correctly.

cmonr · 2018-05-23T19:22:30Z

@li-ho I'm glad you noticed, but the description style has been updated a couple of times since I last had this PR open. The style that is present now is correct and in line with other PRs.

cmonr · 2018-05-24T15:31:31Z

/morph build

mbed-ci · 2018-05-24T17:31:03Z

Build : SUCCESS

Build number : 2140
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6433/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-05-24T18:53:01Z

Test : SUCCESS

Build number : 1933
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6433/1933

mbed-ci · 2018-05-24T19:32:16Z

Exporter Build : SUCCESS

Build number : 1765
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6433/

cmonr requested review from theotherjimmy, geky and 0xc0170 March 22, 2018 20:00

cmonr added the needs: review label Mar 22, 2018

cmonr force-pushed the python3-in-travisci branch from ca594b3 to c48ff37 Compare March 22, 2018 20:04

theotherjimmy previously approved these changes Mar 22, 2018

View reviewed changes

geky reviewed Mar 23, 2018

View reviewed changes

0xc0170 previously approved these changes Mar 23, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Mar 23, 2018

0xc0170 added ready for merge and removed needs: CI labels Mar 23, 2018

cmonr added the release-version: 5.8.1 label Mar 23, 2018

0xc0170 added release-version: 5.9.0-rc1 and removed release-version: 5.8.1 labels Mar 26, 2018

cmonr closed this Mar 26, 2018

cmonr removed ready for merge release-version: 5.9.0-rc1 labels Mar 26, 2018

cmonr reopened this May 23, 2018

cmonr added the release-version: 5.9.0-rc1 label May 23, 2018

Updated Travis CI to be able to run tool tests against Python 3.

8b66182

Will be enabled when tool support has been completely ported

cmonr dismissed 0xc0170’s stale review via 8b66182 May 23, 2018 00:21

cmonr dismissed theotherjimmy’s stale review via 8b66182 May 23, 2018 00:21

cmonr force-pushed the python3-in-travisci branch from c48ff37 to 8b66182 Compare May 23, 2018 00:21

cmonr added the needs: review label May 23, 2018

cmonr added needs: CI and removed needs: review labels May 24, 2018

0xc0170 approved these changes May 24, 2018

View reviewed changes

cmonr merged commit 2eac96e into ARMmbed:master May 24, 2018

cmonr removed the needs: CI label May 24, 2018

Enabl-able Python 3 tools testing in Travis CI #6433

Enabl-able Python 3 tools testing in Travis CI #6433

Uh oh!

Conversation

cmonr commented Mar 22, 2018 • edited by geky Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Uh oh!

theotherjimmy commented Mar 22, 2018

Uh oh!

theotherjimmy left a comment

Choose a reason for hiding this comment

Uh oh!

cmonr commented Mar 22, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Mar 23, 2018

Uh oh!

mbed-ci commented Mar 23, 2018

Triggering tests

Uh oh!

mbed-ci commented Mar 23, 2018

Uh oh!

mbed-ci commented Mar 23, 2018

Uh oh!

theotherjimmy commented Mar 23, 2018

Uh oh!

cmonr commented Mar 26, 2018

Uh oh!

cmonr commented May 23, 2018

Uh oh!

li-ho commented May 23, 2018

Uh oh!

mbed-ci commented May 23, 2018

Triggering tests

Uh oh!

mbed-ci commented May 23, 2018

Uh oh!

cmonr commented May 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmonr commented May 23, 2018

Uh oh!

cmonr commented May 24, 2018

Uh oh!

mbed-ci commented May 24, 2018

Triggering tests

Uh oh!

mbed-ci commented May 24, 2018

Uh oh!

mbed-ci commented May 24, 2018

Uh oh!

Uh oh!

cmonr commented Mar 22, 2018 •

edited by geky

Loading

cmonr commented May 23, 2018 •

edited

Loading