Skip to content

Enabl-able Python 3 tools testing in Travis CI #6433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2018
Merged

Enabl-able Python 3 tools testing in Travis CI #6433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
language: python
python:
'2.7'
python: 2.7

env:
global:
Expand Down Expand Up @@ -30,6 +29,7 @@ before_install:
- sudo ln -s $HOME/.cache/apt /var/cache/apt/archives
# Setup ppa to make sure arm-none-eabi-gcc is correct version
- sudo add-apt-repository -y ppa:team-gcc-arm-embedded/ppa
- sudo add-apt-repository -y ppa:deadsnakes/ppa
# Loop until update succeeds (timeouts can occur)
- travis_retry $(! sudo apt-get update 2>&1 |grep Failed)

Expand Down Expand Up @@ -72,14 +72,16 @@ matrix:
find -name "*.s" | tee BUILD/badasm |
sed -e "s/^/Bad Assembler file name found: /" && [ ! -s BUILD/badasm ]

- env:
- NAME=tools
- &tools-pytest
env: NAME=tools-py2.7
python: 2.7
install:
# Install dependencies
- sudo apt-get install gcc-arm-embedded
- pip install -r requirements.txt
- pip install pytest pylint hypothesis mock coverage coveralls
# Print versions we use

- arm-none-eabi-gcc --version
- python --version
script:
Expand All @@ -94,6 +96,14 @@ matrix:
# Report success since we have overridden default behaviour
- bash -c "$STATUS" success "Local $NAME testing has passed"

# - <<: *tools-pytest
# env: NAME=tools-py3.5
# python: 3.5
#
# - <<: *tools-pytest
# env: NAME=tools-py3.6
# python: 3.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

why not turn it on?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore me, I didn't read your message close enough 👍

Let's keep this pr open until python 3 support works again. Maybe we should create a branch for python3 work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geky Hmm, a feature branch might not be that bad of an idea, although I'm not confident it's needed. We actually already have some tools in master that are python3 ready, courtesy of @theotherjimmy.

I'd prefer to not keep PRs open as a progress indicator, mainly because I don't like to see PRs linger :)

@0xc0170 thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A branch will quickly become out of date with master and then be rebase hell, I think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough

It just seems strange to merge something that is entirely commented out

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair. The flip side is that devs can enable the functionality to test porting efforts :)


- env:
- NAME=astyle
install:
Expand Down