Support for unit testing #734
Conversation
mbed/mbed.py
Outdated
| if os.path.exists(tool): | ||
| popen([python_cmd, tool] | ||
| + (["--skip-build"] if skip_build else []) | ||
| + (["--skip-run"] if skip_run else []) |
There was a problem hiding this comment.
Instead of using --skip-build and --skip-run, could you use --compile and --run like the existing mbed test command? So it's an "opt-in" instead of "opt-out". It would make the testing experience more parallel with what already exists.
mbed/mbed.py
Outdated
| @subcommand('unittest', | ||
| dict(name='--skip-build', action='store_true', help='skip build step'), | ||
| dict(name='--skip-run', action='store_true', help='skip run step'), | ||
| dict(name='--clean', action='store_true', help='clean build data'), |
There was a problem hiding this comment.
Can you also add the short version -c? This is present in the other commands that build code.
mbed/mbed.py
Outdated
| dict(name=['-m', '--make-program'], choices=['gmake', 'make', 'mingw32-make', 'ninja'], help='which make program to use'), | ||
| dict(name=['-g', '--generator'], choices=['Unix Makefiles', 'MinGW Makefiles', 'Ninja'], help='which CMake generator to use'), | ||
| dict(name=['-r', '--regex'], help='run tests matching regular expression'), | ||
| dict(name='--build-path', help='specify build path'), |
There was a problem hiding this comment.
Can you please rename this to just --build to be inline with the other mbed commands?
mbed/mbed.py
Outdated
| dict(name=['-m', '--make-program'], choices=['gmake', 'make', 'mingw32-make', 'ninja'], help='Which make program to use'), | ||
| dict(name=['-g', '--generator'], choices=['Unix Makefiles', 'MinGW Makefiles', 'Ninja'], help='Which CMake generator to use'), | ||
| dict(name=['-r', '--regex'], help='Run tests matching regular expression'), | ||
| dict(name='--build', help='Build directory. Default: mbed-os/UNITTESTS/build/'), |
There was a problem hiding this comment.
This default build directory is outside of the normal root BUILD directory, is this something that has already been agreed upon? @theotherjimmy
There was a problem hiding this comment.
Since unit tests use completely different build environment, they will not be part of any mbed-os application and the tools used are separate from other mbed-os tools it would be better to keep the build folders separate in my opinion.
There was a problem hiding this comment.
@lorjala I'm concerned that your build directory will be scanned by the build tools. How are you avoiding that?
There was a problem hiding this comment.
@theotherjimmy UNITTESTS directory has .mbedignore file, but it could be a possibility to add .mbedignore into the build directory as well during the folder creation if that is the concern.
There was a problem hiding this comment.
👍 That will work. I have the same concern as Brian: why change the default? it has the potential to confuse users, and I can see no upside.
There was a problem hiding this comment.
😉 Defaults to BUILD/unittests for now. Let's see how it works.
|
@theotherjimmy @bridadan Could one of you please merge this? |
|
@lorjala @theotherjimmy @bridadan @MarceloSalazar Why not have this under |
|
@screamerbg Is this OK to merge? |
|
from @OPpuolitaival's linked comment
I think that's a satisfactory explanation. Perhaps you would like to use a different subcommand? |
|
@theotherjimmy Yeah. I'm not happy that unittesting is very internal to Mbed OS development as a product, which won't apply for 99.9% of the Mbed OS users. |
|
@lorjala @OPpuolitaival We have |
|
I'm also open to |
|
LGTM. Great work @theotherjimmy! |
|
@theotherjimmy Merge at will |
Add support for Mbed OS unit testing.
related mbed-os PR: ARMmbed/mbed-os#7819