icetea support #731
icetea support #731
Conversation
mbed/mbed.py
Outdated
| applications_to_add = proc.stdout.read() | ||
| # Filter right row in case that debugger print something there | ||
| if applications_to_add and 'TEST_APPS-' in applications_to_add: | ||
| applications_to_add = filter(lambda x: 'TEST_APPS-' in x, applications_to_add.split('\n'))[0] |
There was a problem hiding this comment.
This does not work in python3: filter is not index-able.
|
Py3 issue fixed in ARMmbed/mbed-os#7769 |
OPpuolitaival
force-pushed
the
icetea
branch
2 times, most recently
from
49e5381 to
5244706
Compare
mbed/mbed.py
Outdated
| env=env) | ||
| # Greentea tests | ||
| if greentea: | ||
| greentea_command = ['mbedgt', '--test-spec', test_spec] \ |
There was a problem hiding this comment.
Looks like the if run_list check has been dropped for greentea here. Could this be added back since it is present for icetea below?
There was a problem hiding this comment.
I don't get the idea.. can you explain a bit more?
| tests_by_name_temp = tests_by_name if tests_by_name else '' | ||
| if icetea: | ||
| proc = popen(icetea_command_base + ['--application-list'], stdin=subprocess.PIPE, stdout=subprocess.PIPE, | ||
| stderr=subprocess.STDOUT) |
There was a problem hiding this comment.
Is the stdout output a comma separated string? Like test1,test2,test3? Just trying to understand this block.
There was a problem hiding this comment.
it is something like:
TEST_APPS-Something
TEST_APPS-Something_else
|
@theotherjimmy anything need to do before merge? I don't see anything |
|
@OPpuolitaival LGTM. Thanks for all your working on this! Please address @bridadan's comment. |
|
@screamerbg now fixed.. |
Add support for icetea tests