This repository was archived by the owner on Apr 24, 2019. It is now read-only.
Merge memory opt to master #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix static resource handling(PUT,POST,DELETE)
Remove separate resource_type_len field from sn_nsdl_static_resource_parameters_s. Make the resource_type_ptr to be "char*" instead of "uint8_t*" to make it clearer that the data is a zero temrinated string from now on. This saves some memory and makes it easier to fill this structure from client side. We're exposing API from C++ side for application to optionally provide this struct as pre-filled const static data from ROM.
There is no need to have separate interface_description_len field, if the string is zero terminated. This saves some memory and eases filling the structure at application side. While here, make the interface_description_ptr to be "char*" instead of "uint8_t*" to document the data type.
Removal of previous field left variables not naturally aligned, so we need to reorganize them to avoid padding.
Use unsigned int for bitfields for C99 compliance
… message Reset message is now passed into application and mbed-client will use the token to match request to right object. With this change we get rid of unnecessary uri_path() API in mbed-client side.
Revert 3b172c6 Notify client when observation is cancelled with RESET…
* Assert not needed in sn_nsdl_build_registration_body since params are checked already when adding resource to list.
build_message_options_uri_path unit tests updated due to commit 91af549
Fix possible null pointer access in assert calls.
Update nsdl and grs unit tests to work with memory optimization changes
Remove assert() for now, let's bring it back later when we have better platform and test framework support for it.
Remove assert macro usage due to comments in review
Remove unnecessary if clause in sn_grs_mark_resources_as_registered
The sn_grs_put_resource() needs a counterpart for removing the structure from the list. This makes it possible to manage the lifetime of nsdl structures from client code.
nsdl: add sn_grs_pop_resource function
anttiylitokola
approved these changes
Jan 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.