Skip to content

Test policy on reload #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Test policy on reload #106

wants to merge 3 commits into from

Conversation

gilles-peskine-arm
Copy link
Collaborator

@gilles-peskine-arm gilles-peskine-arm commented May 13, 2019 •
edited
Loading

Minor improvements to PSA crypto tests around key policies:

  • Test that the key policy of a persistent imported key is properly saved and restored.
  • Add a few more negative test cases for policy enforcement.

@gilles-peskine-arm
Align test functions to usage/alg parameter order
bea99a7
@gilles-peskine-arm
Persistent key reload: test more metadata
3da71c8 
In the tests for opening a persistent key after closing it, also read
back and check the key data if permitted by policy, and the key
policy.
@gilles-peskine-arm gilles-peskine-arm added enhancement New feature or request needs: review The pull request is ready for review. This generally means that it has no known issues. labels May 13, 2019
@gilles-peskine-arm
Add some negative tests for policy checks
65958fb 
Add a few test cases to ensure that alg=0 in policy does not allow
using the key for an operation.

Add a test case to ensure that ANY_HASH does not have a wildcard
meaning for HMAC.
Patater
Patater reviewed May 14, 2019
View reviewed changes
Copy link
Contributor

@Patater Patater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me. One question about test name is all.

Patater
Patater approved these changes May 14, 2019
View reviewed changes
Copy link
Contributor

@Patater Patater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Jul 30, 2019
Merged
@gilles-peskine-arm
Copy link
Collaborator Author

Superseded by #192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patater Patater Patater approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request needs: review The pull request is ready for review. This generally means that it has no known issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gilles-peskine-arm @Patater