Add some negative tests for policy checks #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a few test cases to ensure that alg=0 in policy does not allow using the key for an operation. Add a test case to ensure that ANY_HASH does not have a wildcard meaning for HMAC.
gilles-peskine-arm
added
enhancement
Closed
k-stachowiak
approved these changes
Aug 9, 2019
|
The PR-head job had an unexplained failure (missing logs). I re-ran the PR-merge job, which has the benefit of an up-to-date merge target, and it passed except for the ABI check which doesn't matter on the API branch. |
gilles-peskine-arm
removed
the
needs: review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to get the work from #106 into the product (in the PSA branch, since this is PSA work). It only contains one commit to add test cases. The rest has already gone in through ARMmbed/mbedtls-psa#266.