Prepare for removing crypto from mbedtls #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patater
added
bug
Patater
force-pushed
the
prep-remove-crypto-from-tls
branch
from
acbec07 to
7aa90c6
Compare
|
Rebased to avoid removal of psa_util.h (which is needed by PK and Cipher, both of which continue to be part of Mbed Crypto for the time being), to get cpp_dummy_build passing, to build without Wunused warnings, and to amend the removal of certs.h commit to pass check-generated-files. |
To help the build system find the correct include files, paths starting
with "mbedtls/" or "psa/" must be used. Otherwise, you can run into
build failures like the following when building Mbed Crypto as a
submodule.
In file included from chachapoly.c:31:0:
../../include/mbedtls/chachapoly.h:43:10: fatal error: poly1305.h: No such file or directory
#include "poly1305.h"
^~~~~~~~~~~~
compilation terminated.
Includes for ALT implementations are not modified, as the alt headers
are provided by system integrators and not Mbed TLS or Mbed Crypto.
In configurations wanting an alternative ripemd160 implementation, We were including the ordinary Mbed Crypto ripemd160.h instead of the user-provided ripemd160_alt.h. Use the user-provided header instead.
certs.h is not needed in Mbed Crypto. No programs or other library code use it.
There is now a test that ensures all headers are included in the cpp_dummy_build test, so we can't remove compat-1.3.h from the cpp_dummy_build test until we remove compat-1.3.h. This reverts commit 2b725ef.
Make some functions non-static, to avoid Wunused function warnings. Make a function scoped variable block scoped instead, to avoid Wunused variable warnings in some configurations.
Patater
force-pushed
the
prep-remove-crypto-from-tls
branch
from
7aa90c6 to
f7dca86
Compare
|
Rebased to update base to latest development branch. |
Patater
removed
needs: work
|
Looks good to me. |
Patater
removed
the
needs: review
This was referenced Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of work on removing duplicate crypto files from Mbed TLS, some changes are needed in Mbed Crypto. As part of doing this work, a few minor bugs were discovered and fixed as well.