Improve speed of PBKDF2 by caching the digest state of the passphrase #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! We'll review it as soon as we can. The CI failures are a known issue which is unrelated to this PR. |
gilles-peskine-arm
added
the
needs: review
gilles-peskine-arm
approved these changes
Sep 24, 2019
k-stachowiak
approved these changes
Sep 25, 2019
|
CI is ok except for some TLS tests that failed due to an unrelated issue in mbedtls (since fixed). |
gilles-peskine-arm
added a commit
to Mbed-TLS/mbedtls
that referenced
this pull request
Oct 8, 2019
Update crypto submodule: * ARMmbed/mbed-crypto#277: Improve speed of PBKDF2 by caching the digest state of the passphras * ARMmbed/mbed-crypto#269: Add PSA API versioning * ARMmbed/mbed-crypto#278: Fix on target test issues * ARMmbed/mbed-crypto#286: Fix defgroup syntax for API version section * ARMmbed/mbed-crypto#75: ASN.1 tests without x509
gilles-peskine-arm
added a commit
to gilles-peskine-arm/mbed-crypto
that referenced
this pull request
Nov 15, 2019
* ARMmbed#277: Improve speed of PBKDF2 by caching the digest state of the passphrase * ARMmbed#269: Add PSA API versioning * ARMmbed#278: Fix on target test issues * ARMmbed#286: Fix defgroup syntax for API version section * ARMmbed#75: ASN.1 tests without x509
Patater
pushed a commit
that referenced
this pull request
Jan 15, 2020
Check array index range in GCM multiplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mbedtls_md_hmac_starts computes a hash block consisting of H(passphrase xor ipad), but this operations is performed again and again during the PBKDF2 computation even though it always produces the same result. Instead call
mbedtls_md_hmac_startsonce at the start of computation and usembedtls_md_hmac_restartto reuse the same key again.In my measurements (x86-64 machine, gcc, using SHA-256, 1 million iterations) this is about 10% faster than the current code, which matters quite a lot eg on a server which regularly validates user logins against a hash database.