Fix on target test issues #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 24, 2019 11:21
Reduce the stack usage of the `test_suite_pk` by reducing the size of the buffers used in the tests, to a reasonable big enough size.
Reduce the stack usage of the `test_suite_rsa` by reducing the size of the buffers used in the tests, to a reasonable big enough size, and change the data size to decrypt in the data file.
Reduce the stack usage of the `test_suite_pkcs1_v21` by reducing the size of the buffers used in the tests, to a reasonable big enough size, and change the size sent to the API to sizeof output.
Increase the test suite timeouit from 180 seconds, to 800 seconds, since some tests consume more time, even if all tests are skipped.
Reduce the stack usage of the `test_suite_pkcs1_v15` by reducing the size of the buffers used in the tests, to a reasonable big enough size.
The uint32 is given as a bigendian stream, in the tests, however, the char buffer that collected the stream read it as is, without converting it. Add a temporary buffer, to call `greentea_getc()` 8 times, and then put it in the correct endianity for input to `unhexify()`.
|
I believe CI failure will be fixed with Mbed-TLS/mbedtls#2858 |
This was referenced Sep 24, 2019
Patater
reviewed
Sep 24, 2019
tests/suites/target_test.function
Outdated
| }; | ||
| assert( unhexify( &value, c ) != 8 ); | ||
| return( (uint32_t)value ); | ||
| uint8_t c_be[8] = { greentea_getc(), |
There was a problem hiding this comment.
Did we need to drop const from c_be here? Could we put it back?
dgreen-arm
reviewed
Sep 24, 2019
Patater
added
needs: backports
Add const type that was accidently removed.
RonEld
added
needs: review
|
@Patater @dgreen-arm I have added the 'const' type. Please review |
Patater
approved these changes
Sep 25, 2019
dgreen-arm
approved these changes
Sep 25, 2019
Patater
added
enhancement
This was referenced Sep 25, 2019
|
Backported to the Mbed TLS repo in : Mbed-TLS/mbedtls#2864 and Mbed-TLS/mbedtls#2866 ( stack reduction changes only, as On Target Tests not available in |
Patater
removed
needs: backports
gilles-peskine-arm
added a commit
to Mbed-TLS/mbedtls
that referenced
this pull request
Oct 8, 2019
Update crypto submodule: * ARMmbed/mbed-crypto#277: Improve speed of PBKDF2 by caching the digest state of the passphras * ARMmbed/mbed-crypto#269: Add PSA API versioning * ARMmbed/mbed-crypto#278: Fix on target test issues * ARMmbed/mbed-crypto#286: Fix defgroup syntax for API version section * ARMmbed/mbed-crypto#75: ASN.1 tests without x509
Closed
gilles-peskine-arm
added a commit
to gilles-peskine-arm/mbed-crypto
that referenced
this pull request
Nov 15, 2019
* ARMmbed#277: Improve speed of PBKDF2 by caching the digest state of the passphrase * ARMmbed#269: Add PSA API versioning * ARMmbed#278: Fix on target test issues * ARMmbed#286: Fix defgroup syntax for API version section * ARMmbed#75: ASN.1 tests without x509
Patater
pushed a commit
that referenced
this pull request
Jan 15, 2020
…iming-side-channel ECDSA timing side channel due to non-constant-time integer comparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR Mbed-TLS/mbedtls#2230 to mbed-crypto repository and add a commit from #162 to have the on target tests build and run