Change the compatibility API to inline functions #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Soby. Making the old function names be static inline functions rather than macros is ok. However, you'll need to change several things to pass the CI. I think the functions should return Please ensure that the CI passes. In particular, run |
gilles-peskine-arm
added
enhancement
This patch changes the compatibility API defined in crypto_compat.h to static inline functions as the previous macro definitions were causing issues for the C pre-processor when included in projects which need to redefine the PSA function names. Making it static inline function solves this problem neatly and also modern compilers do a good job at inlining the function which makes the need for making it a macro redundant. Signed-off-by: Soby Mathew <[email protected]>
soby-mathew
force-pushed
the
sm/static_fns_compat
branch
from
4c7c3b4 to
0a4270d
Compare
|
Thanks Gilles. I have updated with new patch. |
|
CI is failing only on a known unrelated issue on Mbed OS, so that's as good as a pass. |
gilles-peskine-arm
added
needs: review
gilles-peskine-arm
approved these changes
Feb 11, 2020
mpg
removed
the
needs: review
gilles-peskine-arm
pushed a commit
to gilles-peskine-arm/mbed-crypto
that referenced
this pull request
Mar 23, 2020
* ARMmbed#365 Change PSA compatibility API to inline functions * ARMmbed#367 Fix pk_parse_key()'s use of rsa_complete() * ARMmbed#370 Bump version to Mbed TLS 2.21.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the compatibility API defined in crypto_compat.h
to static inline functions as the previous macro definitions were
causing issues for the C pre-processor when included in projects
which need to redefine the PSA function names. Making it static
inline function solves this problem neatly and also modern compilers
do a good job at inlining the function which makes the need for making
it a macro redundant.
Signed-off-by: Soby Mathew [email protected]