Skip to content

Bump version to Mbed TLS 2.21.0 #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

yanesca
Copy link
Collaborator

@yanesca yanesca commented Feb 19, 2020

Not bumping the SO version:

The API/ABI breaking changes only affect internal APIs (changes related to mbedtls_asn1_traverse_sequence_of()) and to PSA, which is from the point of view of Mbed TLS is an unstable API.

@yanesca yanesca added needs: review The pull request is ready for review. This generally means that it has no known issues. needs: ci Needs a passing full CI run labels Feb 19, 2020
@gilles-peskine-arm
Copy link
Collaborator

Don't we need to update the crypto submodule and the changelog first?

@yanesca
Copy link
Collaborator Author

yanesca commented Feb 19, 2020

This is mbed-crypto, it does not have it's own version reporting, it reports the Mbed TLS version it is included in. I wanted to update the version here first so that we can do a single submodule update on Mbed TLS instead of two.

Copy link
Collaborator

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. To be immediately followed by updating the submodule and updating the library version in mbedtls.

@gilles-peskine-arm gilles-peskine-arm added ready for merge Design and code approved, CI passed, and likewise for backports. Label added by gatekeepers only. and removed needs: review The pull request is ready for review. This generally means that it has no known issues. needs: ci Needs a passing full CI run labels Feb 19, 2020
@yanesca yanesca added needs: ci Needs a passing full CI run and removed ready for merge Design and code approved, CI passed, and likewise for backports. Label added by gatekeepers only. labels Feb 19, 2020
@yanesca
Copy link
Collaborator Author

yanesca commented Feb 19, 2020

The CI failures are mostly an issue in Mbed OS, with one exception, which is an ssl-opt.sh DTLS spurious resend. All of these are known issues unrelated to this PR.

@yanesca yanesca added ready for merge Design and code approved, CI passed, and likewise for backports. Label added by gatekeepers only. and removed needs: ci Needs a passing full CI run labels Feb 19, 2020
@yanesca yanesca merged commit cf4a40b into ARMmbed:development Feb 19, 2020
gilles-peskine-arm pushed a commit to gilles-peskine-arm/mbed-crypto that referenced this pull request Mar 23, 2020
* ARMmbed#365 Change PSA compatibility API to inline functions
* ARMmbed#367 Fix pk_parse_key()'s use of rsa_complete()
* ARMmbed#370 Bump version to Mbed TLS 2.21.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge Design and code approved, CI passed, and likewise for backports. Label added by gatekeepers only.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants