Custom target filename #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juhhov
reviewed
Dec 13, 2018
move new optional parameter end of public API arguments with default value to avoid breaking changes. Update existing tests
jupe
commented
Dec 13, 2018
| @@ -85,7 +85,7 @@ def can_flash(target): | |||
| return True | |||
|
|
|||
| # pylint: disable=too-many-return-statements, duplicate-except | |||
| def flash(self, source, target, method, no_reset): | |||
| def flash(self, source, target, method, no_reset, target_filename): | |||
There was a problem hiding this comment.
what do you think, is this "public API" ? I would say no... Note that this change is breaking change if we think about this is public API..
There was a problem hiding this comment.
It should not break if default value is given for the target_filename. When the value is default it should work as before this change.
There was a problem hiding this comment.
Anyway, this is not public API IMO either.
Wrong parameters were used.
|
Why problem(s) does this PR solve? |
added 6 commits
December 17, 2018 13:45
This reverts commit 689f984.
|
@jupe could this be merged? |
|
Add test for cli usage as well. Missing also tests for invalid target filename values. |
added 2 commits
December 19, 2018 12:55
juhhov
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Migrations
NO
Description
introduce optional
--target_filename <filename>-parameterNOTE: implemented top of #145
Todos