Platform specific file copying #145
Conversation
|
add Jira link to PR desciption? |
|
why py3 fails? |
mbed_flasher/flashers/FlasherMbed.py
Outdated
| self.logger.exception("File couldn't be copied") | ||
| raise FlashError(message="File couldn't be copied", | ||
| return_code=EXIT_CODE_OS_ERROR) | ||
|
|
||
| def _copy_file_windows(self, source, destination): | ||
| command = "copy \"{}\" \"{}\"".format(os.path.abspath(source), destination) |
| def _copy_file_windows(self, source, destination): | ||
| command = "copy \"{}\" \"{}\"".format(os.path.abspath(source), destination) | ||
| self.logger.debug("Copying with command: {}".format(command)) | ||
| subprocess.check_call(command) |
There was a problem hiding this comment.
this is still an problem, need some change
There was a problem hiding this comment.
Why is it a problem?
There was a problem hiding this comment.
I think you figured out it already 👍
There was a problem hiding this comment.
I don't understand the purpose to start a new command interpreter, would mind explain a bit?
C:\>cmd /?
Starts a new instance of the Windows XP command interpreter
There was a problem hiding this comment.
It is one way to avoid using shell=True, which we do not want to use for security reasons.
juhhov
force-pushed
the
IOTSYSTOOL-1290
branch
from
5ee7a7f to
a8d2aa6
Compare
Once this change is in, what is the plan to measure whether the system is more robust.. less robust.. same robust? |
That comment is targeted to #143, which does not pass acceptance. The changes this PR brings compared to v0.9.1 are described in description. |
juhhov
force-pushed
the
IOTSYSTOOL-1290
branch
from
10e1455 to
1f38517
Compare
Status
READY
Description
Revert back to platform specific file copying as the current implementation is not robust.
In non windows platforms file is now created with flags:
os.O_CREAT | os.O_TRUNC | os.O_RDWR | os.O_SYNCwith the exception of arm machines which stay:
os.O_CREAT | os.O_TRUNC | os.O_RDWR | os.O_DIRECThttp://man7.org/linux/man-pages/man2/open.2.html
https://jira.arm.com/browse/IOTSYSTOOL-1290