Add support for the VBLUno51 board #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Email from Sarah Marsh (mbed): ************************************ Hi, Here is your daplink board ID: C006 The slug: VBLUNO51 When I execute mbedls, it looks like you have used the DAPLink ID for the NRF51_DK. You need your own unique ID. We are running the tests with the NRF51_DK ID mocked as your platform, but you will need to do the following to be mbed enabled: Please submit a PR against mbed-ls (https://github.com/ARMmbed/mbed-ls), so your board can be detected with our tools. Please also submit a PR against DAPLink (https://github.com/mbedmicro/DAPLink), so that your board is uniquely identifiable. Thanks, Sarah ************************************ The VBLUno51 board was added to mbed-os 5.5.2 released ARMmbed/mbed-os#4629 ARMmbed/mbed-os#4719 Signed-off-by: iotvietmember <[email protected]>
|
@maclobdell @0xc0170 @bridadan @adbridge Could you please review this commit? Thank you |
|
@maclobdell @0xc0170 @bridadan @adbridge I hope that this commit will be reviewed soon. Many thanks |
|
@theotherjimmy Could you please review this commit? Thank you |
|
@iotvietmember As it turns out, I don't maintain this repo, and I can't verify that your detect code is correct. |
|
@theotherjimmy thanks |
|
@0xc0170 Could you please reviewed this commit? Thanks |
|
I can confirm that the unique ID used in this PR has been allocated for this platform. So it is good to go! This looks good to me. |
|
Thanks @maclobdell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the VBLUno51 board
Email from Sarah Marsh (mbed):
Hi,
Here is your daplink board ID: C006
The slug: VBLUNO51
When I execute mbedls, it looks like you have used the DAPLink ID for the NRF51_DK. You need your own unique ID. We are running the tests with the NRF51_DK ID mocked as your platform, but you will need to do the following to be mbed enabled:
Please submit a PR against mbed-ls (https://github.com/ARMmbed/mbed-ls), so your board can be detected with our tools.
Please also submit a PR against DAPLink (https://github.com/mbedmicro/DAPLink), so that your board is uniquely identifiable.
Thanks,
Sarah
The VBLUno51 board was added to mbed-os 5.5.2 released
ARMmbed/mbed-os#4629
ARMmbed/mbed-os#4719
Signed-off-by: iotvietmember [email protected]