Add support for VBLUno51 board #4629

iotmember · 2017-06-25T13:22:03Z

Description

This PR add new target for VBLUno51 board (TARGET_VBLUNO51)

VBLUno51 board:
Nordic nRF51822
Bluetooth Low Energy
DAPLink interface
Arduino UNO pinout compatible
4 Power
Uncyclo page

Status

READY

Migrations

NO

Test results

Pass all test case in mbed test suite
test_result_vbluno51.zip

+ VBLUno51 board: Nordic nRF51822 Bluetooth Low Energy DAPLink interface Arduino UNO pinout compatible 4 Power + Uncyclo: https://vngiotlab.github.io/vbluno/ + Pass all test case in mbed test suite Signed-off-by: iotvietmember <[email protected]>

0xc0170 · 2017-06-26T08:37:59Z

targets/TARGET_NORDIC/TARGET_NRF5/TARGET_MCU_NRF51822_UNIFIED/sdk_patch/sdk_config.h

-#define CTS_PIN_NUMBER               UART0_CONFIG_PSEL_CTS
-#define RTS_PIN_NUMBER               UART0_CONFIG_PSEL_RTS
+
+/* Use config at PinNames.h file in TARGET_XXXX directory */


what is this fixing? should this be separate commit?

Hi @0xc0170 : My board do not use default config for RTS, CTS pin.

Nordic nRF51822 based boards:

nrf_drv_config.h
#define UART0_CONFIG_PSEL_CTS 10
#define UART0_CONFIG_PSEL_RTS 8

TARGET_NRF51_DK/PinNames.h
CTS_PIN_NUMBER = p10,
RTS_PIN_NUMBER = p8

VBLUno51 board

TARGET_VBLUNO51/PinNames.h
CTS_PIN_NUMBER = p13,
RTS_PIN_NUMBER = p12

I think that should use config for CTS, RTS pin from PinNames.h file.
This change allows each board to use different hardware configurations

Thanks for the explanation.

cc @nvlsianpu

We have the same problem with those hardcoded pins in sdk_config.h see #4488

@andreaslarssonublox : Thanks for your information

Would this fix it @andreaslarssonublox ? Thanks for referencing the issue !

@0xc0170 Yes, removing the CTS_PIN_NUMBER/RTS_PIN_NUMBER defines from sdk_config.h would fix it for us.

Generally I approve this fix. Remove those definition from here instead of comment it.

0xc0170 · 2017-06-26T08:38:43Z

targets/targets.json

+        "supported_form_factors": ["ARDUINO"],
+        "inherits": ["MCU_NRF51_32K_UNIFIED"],
+        "device_has": ["ANALOGIN", "ERROR_PATTERN", "I2C", "I2C_ASYNCH", "INTERRUPTIN", "LOWPOWERTIMER", "PORTIN", "PORTINOUT", "PORTOUT", "PWMOUT", "RTC", "SERIAL", "SERIAL_ASYNCH", "SERIAL_FC", "SLEEP", "SPI", "SPI_ASYNCH", "SPISLAVE"],
+        "release_versions": ["2"],


Is this target only for mbed 2 , not mbed 5 (it inherits from the target that is supporting 5 as well ) ?

Hi @0xc0170 : I have thought that to support mbed-os 5, I need to pay the fee for mbed team. If it is free, I will add mbed-os 5 version for the VBLUno51 board

@0xc0170 , Would you please tell me that I can add mbed-os5 version for the VBLUno51 board (Nordic nRF51822xxAC based)?

I was just asking what is the reason, please leave it as it is for now.

@ 0xc0170, How to select a dedicated detect_code to VBLUno51 board? Thanks

Please write to the mbed support, they will provide you details. There was a similar question asked on developer page, here for reference https://developer.mbed.org/questions/73405/how-is-detect_code-field-in-target-defin/

iotmember · 2017-06-27T11:56:37Z

Hi @0xc0170 , @theotherjimmy : I hope that this PR would be merged soon. Many thanks for your help.

nvlsianpu · 2017-06-27T12:06:22Z

@iotvietmember What with my comment on UART hardcoded pins definition remove?

iotmember · 2017-06-27T13:16:26Z

Hi @nvlsianpu, our board uses Nordic nRF51822 but do not uses default config for UART communication.
RTS PIN: p12
CTS PIN: p13.

I think that should uses config in PinNames.h file

nvlsianpu · 2017-06-27T13:41:07Z

@iotvietmember I mean that you should remove lines: https://github.com/iotvietmember/mbed-os/blob/add_target_vbluno51/targets/TARGET_NORDIC/TARGET_NRF5/TARGET_MCU_NRF51822_UNIFIED/sdk_patch/sdk_config.h#L10-L12 instead of comment it.

Signed-off-by: iotvietmember <[email protected]>

nvlsianpu · 2017-06-27T09:21:46Z

targets/TARGET_NORDIC/TARGET_NRF5/TARGET_MCU_NRF51822_UNIFIED/sdk_patch/sdk_config.h

-#define CTS_PIN_NUMBER               UART0_CONFIG_PSEL_CTS
-#define RTS_PIN_NUMBER               UART0_CONFIG_PSEL_RTS
+
+/* Use config at PinNames.h file in TARGET_XXXX directory */


Generally I approve this fix. Remove those definition from here instead of comment it.

iotmember · 2017-06-27T14:33:12Z

Hi @nvlsianpu : Many thanks for your help.

0xc0170 · 2017-06-27T14:47:25Z

We got now this change (I would propose a separate commit for this logical set - removing those 2 defines) and another PR fixing it as well but came later after this one - #4647

@iotvietmember what would you suggest ? Rebase this to separate adding new target and fixing UART pins?

iotmember · 2017-06-27T15:12:18Z

I think that I can edit title to "Add support for the VBLUno51 board and Remove hardcode UART pins definitions for nRF51822 SoC"

nvlsianpu · 2017-06-28T06:48:28Z

@0xc0170, @iotvietmember - It is also possible to put the removing to #4647. I will do it in a minute if you both want it.

0xc0170 · 2017-06-28T06:58:35Z

@0xc0170, @iotvietmember - It is also possible to put the removing to #4647. I will do it in a minute if you both want it.

It's @iotvietmember call - please let us know. I would suggest having a separate commit for this change within this patch. Thus either here or the 4647, that can do.

iotmember · 2017-06-28T08:42:55Z

Hi @0xc0170, @nvlsianpu #4647 remove hardcode UART pin definitions for nRF52832. My commit will remove hardcode UART pin definitions for nRF51822

0xc0170 · 2017-06-28T09:16:45Z

I confused numbers, great, both are then good to go :-)

For future, any logical change should be in one commit - easier to review, revert in the future or bugfix than mixing different changes within one commit.

iotmember · 2017-06-28T09:21:05Z

I am really sorry. I do not have much experience with git.
Thanks for your help

0xc0170 · 2017-06-28T09:37:19Z

/morph test

mbed-bot · 2017-06-28T17:21:49Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 674

All builds and test passed!

iotmember · 2017-06-29T08:12:50Z

@0xc0170 : I see the good results

Email from Sarah Marsh (mbed): ************************************ Hi, Here is your daplink board ID: C006 The slug: VBLUNO51 When I execute mbedls, it looks like you have used the DAPLink ID for the NRF51_DK. You need your own unique ID. We are running the tests with the NRF51_DK ID mocked as your platform, but you will need to do the following to be mbed enabled: Please submit a PR against mbed-ls (https://github.com/ARMmbed/mbed-ls), so your board can be detected with our tools. Please also submit a PR against DAPLink (https://github.com/mbedmicro/DAPLink), so that your board is uniquely identifiable. Thanks, Sarah ************************************ The VBLUno51 board was added to mbed-os 5.5.2 released ARMmbed/mbed-os#4629 ARMmbed/mbed-os#4719 Signed-off-by: iotvietmember <[email protected]>

Sarah Marsh (mbed) said that the VBLUno51 board could use board ID is C006 The slug: VBLUNO51 The VBLUno51 board was added to mbed-os 5.5.2 released ARMmbed/mbed-os#4629 ARMmbed/mbed-os#4719 Signed-off-by: iotvietmember <[email protected]>

Email from Sarah Marsh (mbed): ************************************ Hi, Here is your daplink board ID: C006 The slug: VBLUNO51 When I execute mbedls, it looks like you have used the DAPLink ID for the NRF51_DK. You need your own unique ID. We are running the tests with the NRF51_DK ID mocked as your platform, but you will need to do the following to be mbed enabled: Please submit a PR against mbed-ls (https://github.com/ARMmbed/mbed-ls), so your board can be detected with our tools. Please also submit a PR against DAPLink (https://github.com/mbedmicro/DAPLink), so that your board is uniquely identifiable. Thanks, Sarah ************************************ The VBLUno51 board was added to mbed-os 5.5.2 released ARMmbed/mbed-os#4629 ARMmbed/mbed-os#4719 Signed-off-by: iotvietmember <[email protected]>

Sarah Marsh (mbed) said that the VBLUno51 board could use board ID is C006 The slug: VBLUNO51 The VBLUno51 board was added to mbed-os 5.5.2 released ARMmbed/mbed-os#4629 ARMmbed/mbed-os#4719 Signed-off-by: iotvietmember <[email protected]>

0xc0170 added needs: review scope: new-target labels Jun 26, 2017

0xc0170 reviewed Jun 26, 2017

View reviewed changes

theotherjimmy changed the title ~~Add support for VBLUno51 board [TARGET_VBLUNO51]~~ Add support for VBLUno51 board Jun 26, 2017

nvlsianpu mentioned this pull request Jun 27, 2017

Remove hardcode UART pins definitions for nRF52832 SoC #4647

Merged

Remove comment in sdk_config.h

96e9325

Signed-off-by: iotvietmember <[email protected]>

nvlsianpu approved these changes Jun 27, 2017

View reviewed changes

0xc0170 removed the needs: review label Jun 28, 2017

0xc0170 added the needs: CI label Jun 28, 2017

0xc0170 added ready for merge and removed needs: CI labels Jun 29, 2017

theotherjimmy merged commit 916bc4d into ARMmbed:master Jun 29, 2017

theotherjimmy added release-version: 5.5.2 and removed ready for merge labels Jun 29, 2017

iotmember mentioned this pull request Jul 21, 2017

Add support for the VBLUno51 board ARMmbed/mbed-ls#187

Merged

iotmember mentioned this pull request Jul 21, 2017

Add support for the VBLUno51 board pyocd/pyOCD#324

Merged

iotmember mentioned this pull request Jul 21, 2017

Add support for the VBLUno51 board ARMmbed/DAPLink#290

Merged

Add support for VBLUno51 board #4629

Add support for VBLUno51 board #4629

Uh oh!

Conversation

iotmember commented Jun 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Status

Migrations

Test results

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 Jun 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iotmember Jun 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iotmember commented Jun 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nvlsianpu commented Jun 27, 2017

Uh oh!

iotmember commented Jun 27, 2017

Uh oh!

nvlsianpu commented Jun 27, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iotmember commented Jun 27, 2017

Uh oh!

0xc0170 commented Jun 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iotmember commented Jun 27, 2017

Uh oh!

nvlsianpu commented Jun 28, 2017

Uh oh!

0xc0170 commented Jun 28, 2017

Uh oh!

iotmember commented Jun 28, 2017

Uh oh!

0xc0170 commented Jun 28, 2017

Uh oh!

iotmember commented Jun 28, 2017

Uh oh!

0xc0170 commented Jun 28, 2017

Uh oh!

mbed-bot commented Jun 28, 2017

Output

Uh oh!

iotmember commented Jun 29, 2017

Uh oh!

Uh oh!

iotmember commented Jun 25, 2017 •

edited

Loading

0xc0170 Jun 26, 2017 •

edited

Loading

iotmember Jun 26, 2017 •

edited

Loading

iotmember commented Jun 27, 2017 •

edited

Loading

0xc0170 commented Jun 27, 2017 •

edited

Loading