Skip to content

Start FPGA getting started guide in target.md #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2019

Conversation

AnotherButler
Copy link
Contributor

Start getting started guide for the FPGA test shield.

Amanda Butler added 2 commits June 12, 2019 16:46
Start getting started guide for the FPGA test shield.
Add more details about connecting the FPGA test shield.
@AnotherButler AnotherButler requested a review from mprse June 13, 2019 16:43
@AnotherButler
Copy link
Contributor Author

ping @mprse

Copy link
Contributor

@mprse mprse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 2 minor comments, otherwise ok.

@@ -85,3 +85,18 @@ The Mbed OS HAL provides a set of conformance tests for the Mbed OS HAL APIs. Yo
```
mbed test -t <toolchain> -m <target> -n mbed-os-tests-mbed_hal*
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if PR ARMmbed/mbed-os#10820 will come in in current form, then:
mbed-os-tests-mbed_hal* -> tests-mbed_hal_fpga_ci_test_shield*.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that this line is for general HAL testing, so please ignore this comment.

1. Add the `FPGA_CI_TEST_SHIELD` component to the Device Under Test in the `targets.json` configuration file.
1. Run the test:

`mbed test -t GCC_ARM -m K66F -n tests-mbed_hal_fpga_ci_test_shield-spi_slave -v`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment spi_slave will be available only on spi feature branch. I suggest selecting different test which will be available on master (e.g. tests-mbed_hal_fpga_ci_test_shield-spi).

@mprse
Copy link
Contributor

mprse commented Jun 19, 2019

@jamesbeyond ping

Update test code to code that points to master instead of a feature branch, as requested in comments.
@AnotherButler
Copy link
Contributor Author

As this has been approved by an engineer, I'm going to merge it. If there are any other updates, please raise them in a new PR.

@AnotherButler AnotherButler merged commit 8f149ab into development Jun 19, 2019
@AnotherButler AnotherButler deleted the AnotherButler-patch-2 branch June 19, 2019 20:36
AnotherButler pushed a commit that referenced this pull request Jun 19, 2019
Apply changes from PR #1083 to v5.13.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants