-
Notifications
You must be signed in to change notification settings - Fork 178
Update links to examples #1258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update links to examples #1258
Conversation
I believe all the code dependency been merged. could you review this PR @AnotherButler |
For cellular, do we use the one in this PR or the official example, which should be kept up to date: https://github.com/ARMmbed/mbed-os-example-cellular/blob/mbed-os-5.15/main.cpp? @adbridge @jamesbeyond |
@AnotherButler I think this is a question for @AnttiKauppila ? |
the content of I agree to keep one, maybe |
@@ -65,7 +65,7 @@ To bring up the network interface: | |||
|
|||
This example establishes connection with the cellular network using Mbed OS CellularInterface. | |||
|
|||
[](https://github.com/ARMmbed/mbed-os-example-cellular/blob/mbed-os-5.14/main.cpp) | |||
[](github.com/ARMmbed/mbed-os-examples-docs_only/blob/master/APIs_NetworkInterfaces/Cellular/main.cpp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mprse could you change the link pointing to https://github.com/ARMmbed/mbed-os-example-cellular/blob/master/main.cpp
Don't worries about https://github.com/ARMmbed/mbed-os-examples-docs_only/tree/master/APIs_NetworkInterfaces/Cellular, I'll create a PR to remove that
Hi @AnotherButler, I updated this link, this PR is good to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR 👍
Update links to the following examples:
Related PR that brings example to https://github.com/ARMmbed/mbed-os-examples-docs_only:
@AnotherButler Please review. Not sure if this is done in the correct way. I think we should wait with this one until the above list is merged.