Skip to content

Update links to examples #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 18, 2020
Merged

Conversation

mprse
Copy link
Contributor

@mprse mprse commented Mar 2, 2020

Update links to the following examples:

  • Platform,
  • IO,
  • RTOS,
  • NFC,
  • Network,
  • Storage.

Related PR that brings example to https://github.com/ARMmbed/mbed-os-examples-docs_only:

@AnotherButler Please review. Not sure if this is done in the correct way. I think we should wait with this one until the above list is merged.

@jamesbeyond
Copy link
Contributor

I believe all the code dependency been merged. could you review this PR @AnotherButler

@AnotherButler
Copy link
Contributor

For cellular, do we use the one in this PR or the official example, which should be kept up to date: https://github.com/ARMmbed/mbed-os-example-cellular/blob/mbed-os-5.15/main.cpp? @adbridge @jamesbeyond

@adbridge
Copy link
Contributor

@AnotherButler I think this is a question for @AnttiKauppila ?

@jamesbeyond
Copy link
Contributor

For cellular, do we use the one in this PR or the official example, which should be kept up to date: https://github.com/ARMmbed/mbed-os-example-cellular/blob/mbed-os-5.15/main.cpp? @adbridge @jamesbeyond

the content of
https://github.com/ARMmbed/mbed-os-examples-docs_only/blob/master/APIs_NetworkInterfaces/Cellular/main.cpp
and
https://github.com/ARMmbed/mbed-os-example-cellular/blob/mbed-os-5.15/main.cpp
are identical.

I agree to keep one, maybe https://github.com/ARMmbed/mbed-os-example-cellular/blob/mbed-os-5.15/main.cpp would be better

@@ -65,7 +65,7 @@ To bring up the network interface:

This example establishes connection with the cellular network using Mbed OS CellularInterface.

[![View code](https://www.mbed.com/embed/?url=https://github.com/ARMmbed/mbed-os-example-cellular)](https://github.com/ARMmbed/mbed-os-example-cellular/blob/mbed-os-5.14/main.cpp)
[![View code](https://www.mbed.com/embed/?url=github.com/ARMmbed/mbed-os-examples-docs_only/blob/master/APIs_NetworkInterfaces/Cellular/)](github.com/ARMmbed/mbed-os-examples-docs_only/blob/master/APIs_NetworkInterfaces/Cellular/main.cpp)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesbeyond
Copy link
Contributor

Hi @AnotherButler, I updated this link, this PR is good to go

Copy link
Contributor

@AnotherButler AnotherButler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍

@AnotherButler AnotherButler merged commit ccf5af2 into ARMmbed:development Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants