Skip to content

Add Network related examples #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

mprse
Copy link
Contributor

@mprse mprse commented Feb 28, 2020

No description provided.

@mprse
Copy link
Contributor Author

mprse commented Feb 28, 2020

DATAFLASHBLOCKDEVICE example fails because it requires DATAFLASH to be added to K64F components list. This is done via mbed_app.json configuration file which is added to the example directory.
The problem is that mbed test probably ignores this file.

@mprse
Copy link
Contributor Author

mprse commented Mar 3, 2020

Solved CI issue. This one is ready to go.

@jamesbeyond
Copy link
Contributor

Solved CI issue. This one is ready to go.

Hey @mprse, thanks for the changes, but sorry I might need to ask you split this PR into 3. because they contain examples of several teams. one PR would be difficult for people to review, and slow down the merge process.
So I suggested split them into 3:

  • NFC related ->PAN team
  • Storage -> STORAGE team
  • Network and Cellular -> Cellular team

@mprse mprse force-pushed the network_socket_examples branch 2 times, most recently from 69892a7 to dce9bb8 Compare March 4, 2020 07:58
@mprse
Copy link
Contributor Author

mprse commented Mar 4, 2020

@jamesbeyond Split this one as requested:
NFC related ->PAN team (PR #87)
Storage -> STORAGE team (PR #86)
Network and Cellular -> Cellular team (this one)

I also added missing headers.

Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesbeyond
Copy link
Contributor

Hi @AnttiKauppila,
could you have a look, see if you happy about those snippets examples, they been moved from https://github.com/ARMmbed/mbed-os-5-docs/blob/development/docs/api/networksocket/CellularNonIPSocket.md#cellularnonipsocket-example
to here

@mprse
Copy link
Contributor Author

mprse commented Mar 4, 2020

Maybe I should change APIs_networksocket/... to APIs_Network/.... This would be more generic and suitable also for examples like:
https://os.mbed.com/teams/mbed_example/code/TCPSocket_Example/file/50f1485931f1/main.cpp/

@jamesbeyond
Copy link
Contributor

Maybe I should change APIs_networksocket/... to APIs_Network/.... This would be more generic and suitable also for examples like:
https://os.mbed.com/teams/mbed_example/code/TCPSocket_Example/file/50f1485931f1/main.cpp/

Maybe APIs_NetworkSocket/... with little changes on the caps to match all others? in the documents, it is under NetworkSocket page :
https://os.mbed.com/docs/mbed-os/v5.15/apis/non-ip-cellular-socket.html

@mprse mprse force-pushed the network_socket_examples branch from dce9bb8 to f43475a Compare March 11, 2020 18:38
@mprse
Copy link
Contributor Author

mprse commented Mar 11, 2020

Rebased and updated directory name as suggested.

@jamesbeyond jamesbeyond merged commit 7810387 into ARMmbed:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants