Update DeepSleepLock #316
Merged
Update DeepSleepLock #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove content that is not relevant, add new example and update description.
|
@sg- can you review this? |
sg-
reviewed
Oct 28, 2017
There was a problem hiding this comment.
Great stuff! Have a look at the RAII intro from CriticalSection. Probably a few things to steal and move here as well. https://github.com/ARMmbed/Handbook/pull/298/files
Add a page for the SleepManager API. This contains general sleep information, along with the sleep manager API and an example which uses it.
c1728p9
force-pushed
the
deep_sleep_lock
branch
from
8560df5 to
de95a74
Compare
|
@sg- I updated this PR to talk about the constructor and destructor of RAII objects as #298 does. |
Make minor formatting change for proper rendering.
AnotherButler
approved these changes
Oct 30, 2017
sg-
approved these changes
Oct 30, 2017
|
|
||
| ### Example | ||
|
|
||
| [](https://os.mbed.com/users/c1728p9/code/SleepManager_Example_1/file/e85412b4147e/main.cpp) |
There was a problem hiding this comment.
Query: Is there any way to put this in the same teams location as the other examples?
There was a problem hiding this comment.
Yep, I updated this to point to that.
Update URL to use the mbed_example team for the example link rather than a personal repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the DeepSleepLock page along with moving content from this page to a new sleep manager page.