Skip to content

Add PSA overview page #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 28, 2018
Merged

Add PSA overview page #815

merged 5 commits into from
Nov 28, 2018

Conversation

danny4478
Copy link
Contributor

No description provided.

@danny4478 danny4478 force-pushed the danny_spm_overview_br branch from 5a43d5c to c27da20 Compare November 6, 2018 10:49
Amanda Butler added 2 commits November 12, 2018 21:42
Edit psa.md
424814c 
Edit file, mostly for consistent tone and style.
Update security.md
f863de5 
Delete extra phrasing to match our tone.
AnotherButler
AnotherButler reviewed Nov 13, 2018
View reviewed changes
Copy link
Contributor

@AnotherButler AnotherButler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few queries for you to address. Nice work on this 👍

Add links to psa.md
2e941d8 
Add links to glossary. A separate PR is up to add them there.
@AnotherButler
Copy link
Contributor

Related: danny4478#3

Update psa.md
967caa4 
Fix phrasing for clarity and correct branding.
@AnotherButler
Copy link
Contributor

AnotherButler commented Nov 16, 2018 •
edited
Loading

This PR is waiting on engineering approval and two code dependencies.

@AnotherButler
Copy link
Contributor

Depends on ARMmbed/mbed-os#8745 and ARMmbed/mbed-os#8744

@danny4478
Copy link
Contributor Author

@AnotherButler The diagram link does not work anymore. Is this expected to work?
Please confirm that the png file is not needed anymore under security/png and I will remove the whole png directory.

@mohammad1603 mohammad1603 mentioned this pull request Nov 18, 2018
Closed
@AnotherButler
Copy link
Contributor

@danny4478 The link will work and the image will appear once the image is uploaded to our AWS. That's currently a manual process by the web team, so I'll put in a request to have them do that.

@danny4478
Copy link
Contributor Author

danny4478 commented Nov 27, 2018 •
edited
Loading

@AnotherButler ARMmbed/mbed-os#8745 will not make it into 5.11.
ARMmbed/mbed-os#8744 will probably be labeled as ready-to-merge by the end of the day.

  • Is this the last thing stopping this PR from being merged?
  • Do we need someone from engineering to approve? Can it be @alzix or need someone outside the team?

@AnotherButler
Copy link
Contributor

@danny4478 Awesome. We need one engineer who didn't write the PR to approve. It can be @alzix or another engineer from the team.

@danny4478
Copy link
Contributor Author

@orenc17 Can you please review?

@AnotherButler AnotherButler merged commit 6f0f67f into ARMmbed:development Nov 28, 2018
@AnotherButler AnotherButler deleted the danny_spm_overview_br branch November 28, 2018 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alzix alzix alzix left review comments

@AnotherButler AnotherButler AnotherButler left review comments

@ndevillard ndevillard ndevillard left review comments

@orenc17 orenc17 orenc17 approved these changes

Assignees
No one assigned
Labels
5.11 code dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danny4478 @AnotherButler @alzix @orenc17 @ndevillard