Add new target future sequana PSA #8745

orenc17 · 2018-11-14T16:14:54Z

Description

Adds FUTURE_SEQUANA_PSA & FUTURE_SEQUANA_M0_PSA targets.
Modify original linker scripts to be compatible with bootloader and PSA.
~~Add memory protection.~~
Modify original post-build step to allow link with PSA binaries
Config kvstore for ITS on FUTURE_SEQUANA_PSA

Note to maintainers

This PR adds memory protection to the platform but it is disabled until some performance bugs will be fixed

Dependencies

#8667
#8680
#8730
#8744

Requires #8935
The actual changes of this PR are in commit 1de12db6690d727304893eed26dcff6e72ae6650

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

features/storage/kvstore/conf/tdb_internal/mbed_lib.json

0xc0170 · 2018-11-15T17:03:35Z

Passed, 112 files (+54 files)

Can you please fix the style issues?

[ERROR] ./rtos/TARGET_CORTEX/mbed_rtos_rtx.c:25:10: fatal error: spm_init.h: No such file or directory - Travis error

mikisch81 · 2018-11-15T20:34:50Z

Passed, 112 files (+54 files)

Can you please fix the style issues?

[ERROR] ./rtos/TARGET_CORTEX/mbed_rtos_rtx.c:25:10: fatal error: spm_init.h: No such file or directory - Travis error

Travis error fixed, what astyle issue is there? the astyle tests pass.

cmonr · 2018-11-15T21:43:03Z

@mikisch81 It's not obvious yet because we haven't enabled the failing of the test yet, but if you go to the travis job, the +54 means 54 new files have astyle issues.

Check the console for more details: https://travis-ci.org/ARMmbed/mbed-os/jobs/455670910

MarceloSalazar · 2018-11-15T23:28:11Z

Question: Why would you create a new target FUTURE_SEQUANA_PSA instead of a PSA configuration for FUTURE_SEQUANA, which delelopers could enable using a mbed_app.json?

I understand developers won't be able to use the existing FUTURE_SEQUANA target with this feature on the Online compiler.

@0xc0170 @cmonr can you clarify this please?

alzix · 2018-11-16T07:06:32Z

@MarceloSalazar,
The target we added is conceptually different from FUTURE_SEQUANA. Applying our changes to existing target would be too invasive. We did not want to cancel/modify the default FUTURE_SEQUANA target.
Thinking of PSA as of an optional feature is wrong. It is a property if a target.
Since we did not have PSA infrastructure at the time FUTURE_SEQUANA was ported. We end up with a duplicate target.
I assume that future new targets ports on PSA compliant targets will be done only for the PSA variant.

danny4478 · 2018-11-19T16:20:13Z

targets/TARGET_Cypress/TARGET_PSOC6/TARGET_FUTURE_SEQUANA_M0_PSA/cyprotection.h

+********************************************************************************
+* \copyright
+*
+* � 2018, Cypress Semiconductor Corporation


What are this strange / special characters on Cypress license header? Are we ok with it?
CC @alzix

Can this be cleaned (characters fixed) ?

Also, what license is this? Should be apache 2.0 or known permissive license. Other drivers from Cypress are Apache 2.0

danny4478

LGTM

See one comment about strange character in Cypress license header...
Did not review Cypress code...

alzix · 2018-11-19T16:28:04Z

This target does not have memory protection enabled due to issue with native flash drivers.
Memory protection will be applied in a separate PR. We are working with the vendor on finding a solution/workaround that will allow us to enable memory protection.

Without memory protection this target can not be considered production ready PSA target, and mainly intended for kicking off the integration work.

0xc0170 · 2018-11-22T17:11:39Z

tools/config/init.py

Note there is a conflict now

mikisch81 · 2018-11-22T17:16:39Z

tools/config/init.py

Note there is a conflict now

@0xc0170 yes we are aware, we are waiting for any of the prerequisites to be merged first (especially #8667).

bulislaw · 2018-11-22T19:18:50Z

What's the difference between sequana and PSoC6? Is FUTURE_SEQUANA going to be used for non-PSA and FUTURE_SEQUANA_PSA for PSA? If not what's the deprecation strategy?

alzix · 2018-11-23T08:20:20Z

@bulislaw,

What's the difference between sequana and PSoC6?

32-bit Arm® Cortex®-M4 PSoC® 6 - is the SOC name from Cypress
FUTURE_SEQUANA is a development kit provided by Future Electronics.
There are also other kits with same SOC:

PSoC 6 BLE Pioneer Kit - very similar to FUTURE_SEQUANA but still have some minor pin mappings. Not directly supported by mbed-os, but compatible with FUTURE_SEQUANA
PSoC® 6 WiFi-BT Pioneer Kit - currently not supported be mbed-os as it uses different revision of PSoC6 SOC

Is FUTURE_SEQUANA going to be used for non-PSA and FUTURE_SEQUANA_PSA for PSA? If not what's the deprecation strategy?

No deprecation is expected. Bith targets are valid and serve different purposes.

bulislaw · 2018-11-26T14:50:30Z

All the PRs need to be engineering ready (marked as "needs: CI") by the end of the day (Austin time). Otherwise it won't make 5.11 and will need to come in the next release (5.12 for features, 5.11.1 for fixes and new platforms).

0xc0170 · 2018-12-06T09:11:51Z

@orenc17 Every prebuilt image should have a license (in this case PBL), the license file and Readme describing what is it + license description and what tools were used to compiled it (because of how toolchains versions can break things). Can you please add and we will trigger CI asap

An example of readme: targets/TARGET_RDA/TARGET_UNO_91H/lib/README.md

Why they were added (what was an issue with CI update) ?

0xc0170

License looks good , thanks

0xc0170 · 2018-12-06T09:37:56Z

CI started

mbed-ci · 2018-12-06T10:32:40Z

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 7
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-IAR

0xc0170 · 2018-12-06T10:34:27Z

Please review artifacts, this is the error from the logs [Error] psa_crypto_partition.c@20,46: [Pe260]: explicit type is missing ("int" assumed)

orenc17 · 2018-12-06T11:11:40Z

@0xc0170 run it again, we needed #8935

0xc0170 · 2018-12-06T11:13:02Z

We should first check it, let me try to reproduce locally

0xc0170 · 2018-12-06T11:17:12Z

CI restarted

mbed-ci · 2018-12-06T13:30:10Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 8
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_exporter

cmonr · 2018-12-06T15:31:37Z

@orenc17 This one is a bit interesting.

Blinky failed to link when compiling with the gnuarmeclipse ide.

You can find the failure logs here: http://mbed-os-ci.s3-website-eu-west-1.amazonaws.com/?prefix=jenkins-ci/artifacts/exporter/8745/8/gnuarmeclipse/FAIL/FUTURE_SEQUANA_M0_PSA/

(gnuarmeclipse is very verbose, so the CI uploads an archive instead of just the .log file)

The specific failure can be seen below:
12:57:06 [FUTURE_SEQUANA_M0_PSA:gnuarmeclipse] ./main.o: In function `main': 12:57:06 [FUTURE_SEQUANA_M0_PSA:gnuarmeclipse] /builds/ws/mbed-os-ci_exporter-gnuarmeclipse/FUTURE_SEQUANA_M0_PSA_gnuarmeclipse_890/examples/mbed-os-example-blinky/Debug/../main.cpp:13: multiple definition of `main' 12:57:06 [FUTURE_SEQUANA_M0_PSA:gnuarmeclipse] ./mbed-os/components/TARGET_PSA/spm/COMPONENT_SPE/spm_main.o:/builds/ws/mbed-os-ci_exporter-gnuarmeclipse/FUTURE_SEQUANA_M0_PSA_gnuarmeclipse_890/examples/mbed-os-example-blinky/Debug/../mbed-os/components/TARGET_PSA/spm/COMPONENT_SPE/spm_main.c:24: first defined here 12:57:06 [FUTURE_SEQUANA_M0_PSA:gnuarmeclipse] collect2: error: ld returned 1 exit status 12:57:06 [FUTURE_SEQUANA_M0_PSA:gnuarmeclipse] makefile:254: recipe for target 'mbed-os-example-blinky.elf' failed 12:57:06 [FUTURE_SEQUANA_M0_PSA:gnuarmeclipse] make: *** [mbed-os-example-blinky.elf] Error 1 12:57:06 [FUTURE_SEQUANA_M0_PSA:gnuarmeclipse] 12:57:06 [FUTURE_SEQUANA_M0_PSA:gnuarmeclipse] 12:55:45 Build Finished (took 24s.535ms)

orenc17 · 2018-12-06T15:33:41Z

@cmonr i'm working on a fix

orenc17 · 2018-12-06T15:45:16Z

@cmonr Done

cmonr · 2018-12-06T16:06:23Z

@orenc17 I'm wondering if c4c21d2 is the right way to fix this.

Doesn't this mean that PSA secure targets can no longer be compiled?

orenc17 · 2018-12-06T16:15:40Z

@cmonr No, it means that the secure targets are not release devices
a normal user is not expected to build the secure image, he/she should use the prebuilt one

cmonr · 2018-12-06T16:23:15Z

CI started

mbed-ci · 2018-12-06T18:37:17Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 9
Build artifacts

danny4478 suggested changes Nov 15, 2018

View reviewed changes

features/storage/kvstore/conf/tdb_internal/mbed_lib.json Show resolved Hide resolved

0xc0170 added the needs: review label Nov 15, 2018

0xc0170 requested review from a team November 15, 2018 14:34

cmonr added needs: work and removed needs: review labels Nov 15, 2018

This was referenced Nov 16, 2018

Add PSA-SPM porting guide ARMmbed/mbed-os-5-docs#811

Merged

Add PSA overview page ARMmbed/mbed-os-5-docs#815

Merged

NirSonnenschein added release-version: 5.11.0-rc1 risk: R needs: review and removed needs: work labels Nov 18, 2018

0xc0170 added the needs: preceding PR label Nov 19, 2018

alzix approved these changes Nov 19, 2018

View reviewed changes

danny4478 reviewed Nov 19, 2018

View reviewed changes

danny4478 approved these changes Nov 19, 2018

View reviewed changes

mohammad1603 mentioned this pull request Nov 21, 2018

PSA Crypto SPM #8804

Merged

0xc0170 added release-version: 5.11.1 and removed release-version: 5.11.0-rc1 labels Nov 26, 2018

0xc0170 removed do not merge needs: work labels Dec 6, 2018

Prebuilt images

cb58b34

0xc0170 approved these changes Dec 6, 2018

View reviewed changes

0xc0170 added needs: work and removed needs: CI labels Dec 6, 2018

0xc0170 added needs: CI and removed needs: work labels Dec 6, 2018

cmonr added needs: work and removed needs: CI labels Dec 6, 2018

Ignore PSA secure targets

c4c21d2

cmonr added needs: CI and removed needs: work labels Dec 6, 2018

cmonr merged commit 78d6018 into ARMmbed:master Dec 6, 2018

cmonr removed the needs: CI label Dec 6, 2018

Add new target future sequana PSA #8745

Add new target future sequana PSA #8745

Uh oh!

Conversation

orenc17 commented Nov 14, 2018 • edited by adbridge Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Note to maintainers

Dependencies

Pull request type

Uh oh!

Uh oh!

0xc0170 commented Nov 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mikisch81 commented Nov 15, 2018

Uh oh!

cmonr commented Nov 15, 2018

Uh oh!

MarceloSalazar commented Nov 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alzix commented Nov 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danny4478 Nov 19, 2018

Choose a reason for hiding this comment

Uh oh!

0xc0170 Nov 29, 2018

Choose a reason for hiding this comment

Uh oh!

danny4478 left a comment

Choose a reason for hiding this comment

Uh oh!

alzix commented Nov 19, 2018

Uh oh!

0xc0170 commented Nov 22, 2018

Uh oh!

mikisch81 commented Nov 22, 2018

Uh oh!

bulislaw commented Nov 22, 2018

Uh oh!

alzix commented Nov 23, 2018

Uh oh!

bulislaw commented Nov 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Dec 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Dec 6, 2018

Uh oh!

mbed-ci commented Dec 6, 2018

Test run: FAILED

Uh oh!

0xc0170 commented Dec 6, 2018

Uh oh!

orenc17 commented Dec 6, 2018

Uh oh!

0xc0170 commented Dec 6, 2018

Uh oh!

0xc0170 commented Dec 6, 2018

Uh oh!

mbed-ci commented Dec 6, 2018

Test run: FAILED

Uh oh!

cmonr commented Dec 6, 2018

Uh oh!

orenc17 commented Dec 6, 2018

Uh oh!

orenc17 commented Dec 6, 2018

Uh oh!

cmonr commented Dec 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

orenc17 commented Dec 6, 2018

Uh oh!

orenc17 commented Nov 14, 2018 •

edited by adbridge

Loading

0xc0170 commented Nov 15, 2018 •

edited

Loading

MarceloSalazar commented Nov 15, 2018 •

edited

Loading

alzix commented Nov 16, 2018 •

edited

Loading

bulislaw commented Nov 26, 2018 •

edited

Loading

0xc0170 commented Dec 6, 2018 •

edited

Loading

cmonr commented Dec 6, 2018 •

edited

Loading