Skip to content

Add links to minimal printf library in tutorials section #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2019

Conversation

kegilbert
Copy link
Contributor

No description provided.

@kegilbert kegilbert requested review from a team and marcuschangarm November 20, 2018 23:35
@@ -113,6 +113,9 @@ These tutorials teach you to communicate with your development board, an essenti
<tr>
<td><a href="serial-comm.html">Board to PC communication over USB tutorial</a></td>
</tr>
<tr>
<td><a href="serial-comm.html#minimal-printf">Low memory serial printf</a></td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Query: Does this belong in serial communication, debugging or both?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmm, I'd leave it in serial communication. Wouldn't be completely out of place in debugging, but people tend not to care quite as much about ROM size for debugging purposes and this falls under more of an optimization.

@kegilbert
Copy link
Contributor Author

@marcuschangarm Pinged you offline a while back but looks like you were traveling. This library seems to only save size when built with GCC_ARM. Is that intended? If so will likely update this PR to highlight it as a GCC_ARM optimization.

@AnotherButler
Copy link
Contributor

What's the status on this? Are we waiting on @marcuschangarm ? Or is this good to go?

@kegilbert
Copy link
Contributor Author

Think we're good to go with the note that that it does not work on the ARM compiler.

@AnotherButler AnotherButler merged commit 922f248 into ARMmbed:development Jan 18, 2019
AnotherButler pushed a commit that referenced this pull request Jan 18, 2019
Apply change from #845 to add link to minimal printf library.
AnotherButler pushed a commit that referenced this pull request Jan 18, 2019
Apply change from PR #845 to add link to printf example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants