Skip to content

BLE build time configuration doc #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 1, 2019

Conversation

paul-szczepanek-arm
Copy link
Member

Added a doc for the not yet merged configuration feature (temporary PR: paul-szczepanek-arm/mbed-os#61)


These are feature that can be disabled:

- observer (scanning)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to replace this with a table (config flag and description)?

Copy link
Contributor

@kegilbert kegilbert Feb 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does the BLE mbed_lib.json file live? I was only able to find target specific ones and
mbed compile --config -v --prefix ble doesn't give me anything (tried with a BLE target specified as well).

A section like the other pages if this does exist would be helpful: https://github.com/ARMmbed/mbed-os-5-docs/blob/development/docs/reference/configuration/Platform.md

i.e.:

Configuration parameters
------------------------

Name: ble.beepboop
....

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paul-szczepanek-arm Pinging for above question. If the table in this doc is a list of configuration options available through the config system then the doc config list auto-updater script won't catch it unless it's formatted like the other files:

#948

Copy link
Member Author

@paul-szczepanek-arm paul-szczepanek-arm Feb 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I still need to write this if it's autogenerated? How do I insert the autogenerated part? May I have the script? Nevermind, it's in the PR you linked to.

@AnotherButler
Copy link
Contributor

Tagging @kegilbert as a reviewer because he's working on a script standardizing and automating config docs.

@paul-szczepanek-arm
Copy link
Member Author

markdown does not like breaklines in tables, let me fix that

@paul-szczepanek-arm
Copy link
Member Author

Is this compromise between MD rendering and plain text readability acceptable?

@AnotherButler
Copy link
Contributor

If you like, I can play around with the table and figure out why it's not rendering right.

@paul-szczepanek-arm
Copy link
Member Author

I leave that decision to you. My guess would be that most people read docs as text files but I'm probably just projecting.

Copy link
Contributor

@donatieng donatieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@paul-szczepanek-arm
Copy link
Member Author

@kegilbert Hi, does this work?

Copy link
Contributor

@kegilbert kegilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Make minor copy edits, mostly for active voice and international spelling.
@AnotherButler
Copy link
Contributor

New code dependency: ARMmbed/mbed-os#9790

@AnotherButler AnotherButler merged commit 298b774 into ARMmbed:development Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants