Ble conf #9790

paul-szczepanek-arm · 2019-02-21T10:45:32Z

Description

Allow users to configure the BLE feature to disable functionality not needed by the device to save memory.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@pan-

Release Notes

No changes made to existing programs. By default all options are enabled which is the current state.

paul-szczepanek-arm · 2019-02-21T10:46:29Z

Please add needs work.
This PR relies on a previous PR which is not yet made. This PR for now is for review and visibility.

ciarmcom · 2019-02-21T12:00:52Z

@paul-szczepanek-arm, thank you for your changes.
@pan- @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-pan please review.

pan- · 2019-02-25T08:32:02Z

@0xc0170 We need the 5.12 tag please.

The event handler has been extracted out of the monitor declaration.

The event handler has been taken out of Gap declaration and the instantiation must provide an implementation and the type that plays the event handler role.

The event handler has been taken out of GattClient declaration and an instantiation requires the actual implementation and the type that handle events.

The event handler has been extracted out of SecurityManager declaration and instantion of the interface requires the implementation and event handler type.

The event handler has been extracted out of SigningEventMonitor declaration and SigningEventMonitor instantion requires the implementation and event handler type.

The interface definition now lives in ::ble::interface::LegacyGap. Implementation must export the implementation type as ble::impl::LegacyGap.

The interface definition now lives in ::ble::interface::Gap. The implementation must export the implementation types as ::ble::impl::Gap.

Interface definition now lives in ble::interface::GattClient. An implementation must export the implementation type in ::ble::impl::GattClient.

The interface is defined in ::ble::interface::GattServer and an implementation must export the implementation type ::ble::impl::GattServer.

The interface now lives in ::ble::interface::SecurityManager. The implementation type is expectected to exported as ble ::ble::impl::SecurityManager by the implementation.

paul-szczepanek-arm · 2019-02-28T16:22:57Z

features/FEATURE_BLE/source/services/DFUService.cpp

@@ -14,11 +14,6 @@
 * limitations under the License.
 */

-#include "BLERoles.h"
-
-#if BLE_FEATURE_GATT_SERVER


why? does not compile now

paul-szczepanek-arm · 2019-02-28T16:27:52Z

features/FEATURE_BLE/source/services/UARTService.cpp

@@ -14,11 +14,6 @@
 * limitations under the License.
 */

-#include "BLERoles.h"
-
-#if BLE_FEATURE_GATT_SERVER


does in fact need gattserver

paul-szczepanek-arm · 2019-02-28T16:28:08Z

features/FEATURE_BLE/source/services/URIBeaconConfigService.cpp

@@ -14,11 +14,6 @@
 * limitations under the License.
 */

-#include "BLERoles.h"
-
-#if BLE_FEATURE_GATT_SERVER


reinstate pls

…ngDataLength

pan- · 2019-02-28T16:57:13Z

@paul-szczepanek-arm I've addressed your comments and benchmarked our examples:

Example	TEXT	BSS	DATA
BLE_BatteryLevel	32947 (-66510)	162 (-29)	4817 (-1343)
BLE_Beacon	16240 (-82745)	66 (-125)	3613 (-2547)
BLE_Button	32943 (-66510)	162 (-29)	4817 (-1343)
BLE_GAP	36162 (-63960)	67 (-124)	3958 (-2202)
BLE_GapButton	22680 (-77003)	66 (-125)	3889 (-2271)
BLE_GattClient	34278 (-65255)	78 (-113)	4353 (-1807)
BLE_GattServer	32567 (-66532)	162 (-29)	4817 (-1343)
BLE_Heartrate	32975 (-66512)	162(-29)	4817(-1343)
BLE_LED	32701 (-66752)	162 (-29)	4817 (-1343)
BLE_LEDBlinker	33905 (-64905)	78 (-113)	4360 (-1800)
BLE_PeriodicAdvertising	45953 (-53851)	163 (-28)	4886 (-1274)
BLE_Privacy	52012 (-47160)	94 (-97)	4717 (-1448)
BLE_SM	49652 (-49560)	94 (-97)	4702 (-6160)
BLE_Thermometer	33005 (-66518)	162 (-29)	4817 (-1343)

Note: Numbers provided are just for the BLE API

paul-szczepanek-arm · 2019-02-28T17:00:54Z

features/FEATURE_BLE/ble/services/URIBeaconConfigService.h

@@ -25,6 +25,8 @@

 #endif

+#if BLE_FEATURE_GATT_SERVER
+


still fails

Suggested change

#if BLE_ROLE_BROADCASTER

donatieng · 2019-02-28T23:04:31Z

@armmbed/mbed-os-maintainers this one should be ready for CI

cmonr · 2019-02-28T23:06:17Z

@donatieng Pending a successful merge dryrun test, #9727 will be getting merged. Wanted to wait before that was in.

cmonr · 2019-02-28T23:09:49Z

ETA ~20 mins

donatieng · 2019-02-28T23:10:55Z

Sounds good, thanks @cmonr

cmonr · 2019-03-01T00:06:02Z

Well then. Really glad I did that. A couple things appear to have broken. Checking it out.

Will update when able.

cmonr · 2019-03-01T00:40:55Z

#9790 (comment)

@pan- Thanks for the diff.

cmonr · 2019-03-01T00:41:02Z

CI started

mbed-ci · 2019-03-01T03:08:39Z

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

cmonr · 2019-03-01T03:41:50Z

features/FEATURE_BLE/source/gap/Gap.tpp

@@ -0,0 +1,866 @@
+/* mbed Microcontroller Library


Ooohhh. This was deleted, renamed, then added.

I was wondering why it looked like the GH interface was being weird.

git mv <file>{cpp,tpp} appears to not have been done.

cmonr

This is a really nice refactor!

paul-szczepanek-arm mentioned this pull request Feb 21, 2019

Ble conf paul-szczepanek-arm/mbed-os#61

Closed

0xc0170 added the needs: work label Feb 21, 2019

ciarmcom requested review from pan- and a team February 21, 2019 12:00

ciarmcom added the needs: review label Feb 21, 2019

cmonr removed the needs: work label Feb 21, 2019

0xc0170 added release-version: 5.12.0-rc1 risk: A labels Feb 25, 2019

AnotherButler mentioned this pull request Feb 25, 2019

BLE build time configuration doc ARMmbed/mbed-os-5-docs#949

Merged

paul-szczepanek-arm force-pushed the ble-conf branch from 2506f3c to 3134139 Compare February 26, 2019 10:23

pan- added 16 commits February 26, 2019 13:18

BLE - add static interface helper.

bc098d0

BLE - replace some usages of Gap::Handle_t by ble::connection_handle_t

7e78433

BLE - devirtualize pal::AttClient

333a315

BLE - devirtualize pal::AttClientToGattClientAdapter

71b8d8a

BLE - Devirtualize pal::ConnectionEventMonitor

6514bbd

The event handler has been extracted out of the monitor declaration.

BLE - Devirtualize pal::Gap

0749100

The event handler has been taken out of Gap declaration and the instantiation must provide an implementation and the type that plays the event handler role.

BLE - Devirtualize pal::GattClient

e1371f8

The event handler has been taken out of GattClient declaration and an instantiation requires the actual implementation and the type that handle events.

BLE - Devirtualize pal::SecurityManager

50de4c8

The event handler has been extracted out of SecurityManager declaration and instantion of the interface requires the implementation and event handler type.

BLE - Devirtualize pal::SigningEventMonitor

2d007ee

The event handler has been extracted out of SigningEventMonitor declaration and SigningEventMonitor instantion requires the implementation and event handler type.

BLE - Devirtualization of ::Gap

1ad7263

The interface definition now lives in ::ble::interface::LegacyGap. Implementation must export the implementation type as ble::impl::LegacyGap.

BLE - Devirtualize ::ble::Gap

43e87fb

The interface definition now lives in ::ble::interface::Gap. The implementation must export the implementation types as ::ble::impl::Gap.

BLE - Devirtualize ::GattClient

e56fd68

Interface definition now lives in ble::interface::GattClient. An implementation must export the implementation type in ::ble::impl::GattClient.

BLE - Devirtualize ::GattServer.

6d2592a

The interface is defined in ::ble::interface::GattServer and an implementation must export the implementation type ::ble::impl::GattServer.

BLE - Devirtualize ::SecurityManager

7796e73

The interface now lives in ::ble::interface::SecurityManager. The implementation type is expectected to exported as ble ::ble::impl::SecurityManager by the implementation.

BLE - Cleanup deprecation implementation bits in BLE.cpp

fb39848

BLE - cleanup includes.

e70fb27

paul-szczepanek-arm commented Feb 28, 2019

View reviewed changes

pan- added 5 commits February 28, 2019 16:28

BLE - Exclude services if GattServer is not available.

3142f26

BLE - Fix exclusion of getMaxAdvertisingSetNumber and getMaxAdvertisi…

eeca03f

…ngDataLength

BLE - Fix conditional directive.

74bc677

BLE - Fix conditional directive.

4e172ba

BLE - Filter user facing implementation based on configuration

72e5d3f

paul-szczepanek-arm commented Feb 28, 2019

View reviewed changes

add broadcaster ifdef and pull headers into ifdef

54a866c

donatieng approved these changes Feb 28, 2019

View reviewed changes

pan- approved these changes Feb 28, 2019

View reviewed changes

cmonr added needs: CI risk: A and removed needs: preceding PR needs: work risk: R labels Mar 1, 2019

cmonr reviewed Mar 1, 2019

View reviewed changes

cmonr approved these changes Mar 1, 2019

View reviewed changes

cmonr merged commit f8d254f into ARMmbed:master Mar 1, 2019

cmonr removed the needs: CI label Mar 1, 2019

Ble conf #9790

Ble conf #9790

Uh oh!

Conversation

paul-szczepanek-arm commented Feb 21, 2019

Description

Pull request type

Reviewers

Release Notes

Uh oh!

paul-szczepanek-arm commented Feb 21, 2019

Uh oh!

ciarmcom commented Feb 21, 2019

Uh oh!

pan- commented Feb 25, 2019

Uh oh!

paul-szczepanek-arm Feb 28, 2019

Choose a reason for hiding this comment

Uh oh!

pan- Feb 28, 2019

Choose a reason for hiding this comment

Uh oh!

paul-szczepanek-arm Feb 28, 2019

Choose a reason for hiding this comment

Uh oh!

paul-szczepanek-arm Feb 28, 2019

Choose a reason for hiding this comment

Uh oh!

pan- commented Feb 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paul-szczepanek-arm Feb 28, 2019

Choose a reason for hiding this comment

Uh oh!

donatieng commented Feb 28, 2019

Uh oh!

cmonr commented Feb 28, 2019

Uh oh!

cmonr commented Feb 28, 2019

Uh oh!

donatieng commented Feb 28, 2019

Uh oh!

cmonr commented Mar 1, 2019

Uh oh!

cmonr commented Mar 1, 2019

Uh oh!

cmonr commented Mar 1, 2019

Uh oh!

mbed-ci commented Mar 1, 2019

Test run: SUCCESS

Uh oh!

cmonr Mar 1, 2019

Choose a reason for hiding this comment

Uh oh!

cmonr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pan- commented Feb 28, 2019 •

edited

Loading