workflow: add new target requirement - tests provided #958
Conversation
0xc0170
changed the title
| @@ -90,6 +90,8 @@ Release: feature | |||
|
|
|||
| Updating target implementation (adding a new target or updating already supported target) is a change for a patch release. | |||
|
|
|||
| The test report must be part of the pull request for a new target addition. It must pass all Mbed OS functional and system validation tests for the current Mbed OS major release including all Mbed OS supported toolchains. | |||
There was a problem hiding this comment.
nitpick : "The test report" implies you have referred to it before, which doesn't seem to be the case. Maybe "a test report for the new target" instead.
and also
It must pass all Mbed OS functional and system validation ==> The new target must pass all Mbed OS functional and system validation
There was a problem hiding this comment.
Will fix, cant find test report anywhere. We might encourage testing but t hat will be another PR if any
| @@ -90,6 +90,8 @@ Release: feature | |||
|
|
|||
| Updating target implementation (adding a new target or updating already supported target) is a change for a patch release. | |||
|
|
|||
| The test report must be part of the pull request for a new target addition. It must pass all Mbed OS functional and system validation tests for the current Mbed OS major release including all Mbed OS supported toolchains. | |||
There was a problem hiding this comment.
you might also want to specify a report for which tests as this might not be 100% clear to a new platform developer.
There was a problem hiding this comment.
I would expect to run mbed test for the target (all testing available done). Will check
|
Ok with the text once updates are made. |
|
Updated to address review comments above |
Add comma for clarity.
We always require test results as part of new target. We should have this captured in the documentation.
I've added a new paragraph to "PR type: target update". Or shall this be captured somewhere else?
@ARMmbed/mbed-os-maintainers