Skip to content

workflow: add new target requirement - tests provided #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2019
Merged

workflow: add new target requirement - tests provided #958

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af6b61d
workflow: add new target req
0xc0170 Feb 21, 2019
1331077
workflow: fix review comments
0xc0170 Feb 25, 2019
879c69a
Add comma to workflow.md
Feb 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/reference/contributing/guidelines/workflow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ Release: feature

Updating target implementation (adding a new target or updating already supported target) is a change for a patch release.

The test report must be part of the pull request for a new target addition. It must pass all Mbed OS functional and system validation tests for the current Mbed OS major release including all Mbed OS supported toolchains.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick : "The test report" implies you have referred to it before, which doesn't seem to be the case. Maybe "a test report for the new target" instead.
and also
It must pass all Mbed OS functional and system validation ==> The new target must pass all Mbed OS functional and system validation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix, cant find test report anywhere. We might encourage testing but t hat will be another PR if any

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might also want to specify a report for which tests as this might not be 100% clear to a new platform developer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect to run mbed test for the target (all testing available done). Will check


Release: patch

#### Functionality change
Expand Down