Skip to content

Add EP_Agora config in Json file #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

deepikabhavnani
Copy link

Agora board was added in ARMmbed/mbed-os#10629

PR to be merged after mbed-os.lib is updated to release version 5.13.1 or later

@maclobdell
Copy link

Can these configs be handled in targets.json?

@deepikabhavnani
Copy link
Author

Can these configs be handled in targets.json?

Yes can be

@maclobdell
Copy link

@ARMmbed/team-embeddedplanet Please take a look at these configuration options to enable the BLE stack on Agora. It seems more efficient to add these for your target by default in targets.json. Please evaluate and make a PR if that makes sense to you.

@deepikabhavnani
Copy link
Author

@maclobdell - I checked the targets.json, EP_AGORA inherits from MCU_NRF52840 and it has correct configs set already https://github.com/ARMmbed/mbed-os/blob/master/targets/targets.json#L7253 in master branch.

Example instead should be updated to latest release.

@deepikabhavnani deepikabhavnani deleted the agora_add branch June 27, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants