Add support for the Embedded Planet Agora target #10629

trowbridgec · 2019-05-21T15:25:11Z

Description

Embedded Planet is releasing a board named 'Agora', and this PR will add support for it into the Mbed OS sources.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

trowbridgec · 2019-05-21T15:25:32Z

@ARMmbed/team-embeddedplanet @maclobdell

ciarmcom · 2019-05-21T17:00:43Z

@trowbridgec, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

0xc0170 · 2019-05-23T14:22:48Z

targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/TARGET_MCU_NRF52840/TARGET_EP_AGORA/PinNames.h

@@ -0,0 +1,315 @@
+/*
+ * PinNames.h
+ *


Please add SPDX + license text to new files - review platform files for examples

0xc0170 · 2019-05-23T14:23:03Z

targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/TARGET_MCU_NRF52840/TARGET_EP_AGORA/device.h

+// Check the 'features' section of the target description in 'targets.json' for more details.
+/* mbed Microcontroller Library
+ * Copyright (c) 2006-2013 ARM Limited
+ *


add SPDX please

0xc0170 · 2019-05-23T14:24:13Z

As for new target - please share tests results for all 3 toolchains (required by introducing new target)

trowbridgec · 2019-05-23T15:41:01Z

@0xc0170 Licenses added.

I'll work on getting the test reports.

0xc0170 · 2019-05-23T20:47:21Z

...s/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/TARGET_MCU_NRF52840/TARGET_EP_AGORA/custom_board.h

@@ -0,0 +1,16 @@
+/* mbed Microcontroller Library


why is this empty header file needed?

mbed-ci · 2019-05-23T23:26:15Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

0xc0170

LGTM

Waiting for test results (thus requested changes)

0xc0170 · 2019-05-31T13:11:55Z

Started another run of CI, as the last one was 7 days ago

mbed-ci · 2019-05-31T22:12:03Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_exporter

trowbridgec · 2019-06-03T18:19:06Z

Here's the test log for GCC_ARM:
EP_AGORA_GCC_ARM_Full_test_results.txt

Note: a couple of the tests are failing (tests-mbed_hal-trng and tests-mbed_hal-qspi).

tests-mbed_hal-trng
I was able to get this test to pass by manually pressing the RESET button on my debugger. For some reason, DAPLink wasn't able to reset the target? Log for this test passing individually is here: EP_AGORA_GCC_ARM_tests-mbed_hal-trng.txt
tests-mbed_hal-qspi
Our board fails this test, but so does the nRF52840 DK with the latest DAPLink firmware (253). In both cases, the board is left in a Hard Fault state (LED1 blinking the hard fault pattern).
- EP_AGORA: EP_AGORA_GCC_ARM_tests-mbed_hal-qspi.txt
- NRF52840_DK: NRF52840_DK_GCC_ARM_tests-mbed_hal-qspi.txt

trowbridgec · 2019-06-03T18:24:06Z

Failures above look similar to #10730.

@loverdeg-ep

0xc0170 · 2019-06-04T11:08:48Z

We will schedule CI soon (waiting for rc2 jobs to complete first)

I can see that test change for QSPI had huge impact, I'll ask around to get a fix in place.

0xc0170 · 2019-06-04T12:00:04Z

CI started

0xc0170 · 2019-06-04T12:41:51Z

QSPI test failures are being addressed (PR up already). What about trng? Any other toolchains tested (iar/armcc6) ?

trowbridgec · 2019-06-04T12:57:33Z

@0xc0170 I ran the tests with IAR too and had similar issues for the same tests:
EP_AGORA_IAR_Full_test_results.txt

Running the tests-mbed_hal-trng test manually, I was able to get it to pass by hitting the RESET button at the same time as before:
EP_AGORA_IAR_tests-mbed_hal-trng.txt

The 'Agora' board does not have a DAPLink circuit on board; we debug and program it via an nRF52840 DK running a modified version of DAPLink that forces the interface chip to use the external debug port. I'm not positive, but that could be related?

The test-mbed_hal-qspi test also failed, but that is to be expected with what's being addressed in #10730:
EP_AGORA_IAR_tests-mbed_hal-qspi.txt

mbed-ci · 2019-06-04T13:49:41Z

Test run: FAILED

Summary: 6 of 7 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_mbed2-build-ARM
jenkins-ci/mbed-os-ci_build-IAR
jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_mbed2-build-IAR

0xc0170 · 2019-06-04T14:09:59Z

CI restarted (job was aborted)

mbed-ci · 2019-06-04T19:07:15Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 4
Build artifacts

0xc0170 · 2019-06-05T08:34:31Z

This is ready for integration, almost - @trowbridgec TRNG issue should have tracking issue? QSPI test will be fixed on master after we generate rc2

trowbridgec · 2019-06-05T12:59:40Z

@0xc0170 I created a separate issue for tracking the TRNG test issue: #10765.

0xc0170 · 2019-06-05T13:40:28Z

Thanks, will take it there then. This should be good

0xc0170 · 2019-06-05T13:42:00Z

One last question - IAR and GCC provided, any ARM toolchain tests?

0Grit · 2019-06-05T13:44:18Z

@0xc0170 We have been waiting for a Linux release of Mbed Studio to do those tests.

trowbridgec · 2019-06-05T14:55:44Z

I'm running the ARMC6 tests now, and I'll report back shortly once they finish.

trowbridgec · 2019-06-05T17:19:11Z

ARMC6 tests: EP_AGORA_ARMC6_Full_test_results.txt

Same tests failed as before (tests-mbed_hal-trng and tests-mbed_hal-qspi).

tests-mbed_hal-trng individually passing: EP_AGORA_ARMC6_tests-mbed_hal-trng.txt
tests-mbed_hal-qspi failing as before: EP_AGORA_ARMC6_tests-mbed_hal-qspi.txt

deepikabhavnani · 2019-06-11T15:13:39Z

@trowbridgec - Is the schematic for this hardware available?

deepikabhavnani · 2019-06-11T16:12:18Z

@0xc0170 @trowbridgec - ~~Exporting the project for EP_AGORA gives error:~~

Never mind got export working with uvision6

0Grit · 2019-06-11T17:51:36Z

@deepikabhavnani Let us know or push the fix so we can support others when they have the same issue.

deepikabhavnani · 2019-06-11T17:58:02Z

mbed compile -m EP_AGORA -t ARM defaults to ARMC6 but mbed export -m EP_AGORA -i uVision defaults to uVision5.

CC @0xc0170 - Will this be considered as issue?

@loverdeg-ep - For now I used uVision6 explicitly for export mbed export -m EP_AGORA -i uVision6

Chris Trowbridge added 2 commits May 21, 2019 11:05

Add 'EP_AGORA' as a target

7095c31

Add support files for target EP_AGORA

225f1de

ciarmcom requested a review from a team May 21, 2019 17:00

ciarmcom added the needs: review label May 21, 2019

0xc0170 requested changes May 23, 2019

View reviewed changes

0xc0170 requested a review from MarceloSalazar May 23, 2019 14:23

0xc0170 added release-version: 5.13.0-rc1 scope: new-target labels May 23, 2019

Update licenses for EP_AGORA target

f81130d

0xc0170 self-requested a review May 23, 2019 20:46

0xc0170 reviewed May 23, 2019

View reviewed changes

0xc0170 self-requested a review May 24, 2019 07:51

0xc0170 removed the release-version: 5.13.0-rc1 label May 24, 2019

Remove unneeded custom_board.h file

7531c2b

0xc0170 requested changes May 31, 2019

View reviewed changes

Remove component 'QSPIF' for target 'EP_AGORA'

cea7bbd

0xc0170 approved these changes Jun 4, 2019

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Jun 4, 2019

trowbridgec mentioned this pull request Jun 5, 2019

TRNG Greentea Test requires manual RESET for target EP_AGORA #10765

Closed

0xc0170 added ready for merge and removed needs: CI labels Jun 5, 2019

0xc0170 merged commit 489bd10 into ARMmbed:master Jun 6, 2019

0xc0170 added release-version: 5.13.1 and removed ready for merge labels Jun 6, 2019

trowbridgec deleted the add-target-ep-agora branch June 6, 2019 14:00

deepikabhavnani mentioned this pull request Jun 26, 2019

Add EP_Agora config in Json file ARMmbed/mbed-os-example-ble#247

Closed

Add support for the Embedded Planet Agora target #10629

Add support for the Embedded Planet Agora target #10629

Uh oh!

Conversation

trowbridgec commented May 21, 2019

Description

Pull request type

Reviewers

Release Notes

Uh oh!

trowbridgec commented May 21, 2019

Uh oh!

ciarmcom commented May 21, 2019

Uh oh!

0xc0170 May 23, 2019

Choose a reason for hiding this comment

Uh oh!

0xc0170 May 23, 2019

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented May 23, 2019

Uh oh!

trowbridgec commented May 23, 2019

Uh oh!

0xc0170 May 23, 2019

Choose a reason for hiding this comment

Uh oh!

mbed-ci commented May 23, 2019

Test run: SUCCESS

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented May 31, 2019

Uh oh!

mbed-ci commented May 31, 2019

Test run: FAILED

Uh oh!

trowbridgec commented Jun 3, 2019

Uh oh!

trowbridgec commented Jun 3, 2019

Uh oh!

0xc0170 commented Jun 4, 2019

Uh oh!

0xc0170 commented Jun 4, 2019

Uh oh!

0xc0170 commented Jun 4, 2019

Uh oh!

trowbridgec commented Jun 4, 2019

Uh oh!

mbed-ci commented Jun 4, 2019

Test run: FAILED

Uh oh!

0xc0170 commented Jun 4, 2019

Uh oh!

mbed-ci commented Jun 4, 2019

Test run: SUCCESS

Uh oh!

0xc0170 commented Jun 5, 2019

Uh oh!

trowbridgec commented Jun 5, 2019

Uh oh!

0xc0170 commented Jun 5, 2019

Uh oh!

0xc0170 commented Jun 5, 2019

Uh oh!

0Grit commented Jun 5, 2019

Uh oh!

trowbridgec commented Jun 5, 2019

Uh oh!

trowbridgec commented Jun 5, 2019

Uh oh!

deepikabhavnani commented Jun 11, 2019

Uh oh!

deepikabhavnani commented Jun 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0Grit commented Jun 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

deepikabhavnani commented Jun 11, 2019 •

edited

Loading

0Grit commented Jun 11, 2019 •

edited

Loading

deepikabhavnani commented Jun 11, 2019 •

edited

Loading