Add CMake support #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugueskamba
reviewed
Nov 2, 2020
rajkan01
force-pushed
the
feature-cmake
branch
2 times, most recently
from
99cab36 to
639e002
Compare
hugueskamba
reviewed
Nov 4, 2020
rajkan01
force-pushed
the
feature-cmake
branch
2 times, most recently
from
631790b to
096ce6a
Compare
hugueskamba
approved these changes
Nov 5, 2020
0xc0170
reviewed
Nov 5, 2020
Or not... as not yet enabled for this repo :-) |
|
Wait, to development? This should be to feature-cmake only update, not development |
hugueskamba
added
the
DO NOT MERGE
0xc0170
removed
the
DO NOT MERGE
0xc0170
approved these changes
Nov 9, 2020
|
PR to master was merged. Once CI is green, this is ready for merge |
It is not yet ready to be merged because there is an issue with the tools (ARMmbed/mbed-tools#109). |
|
Ok, this is not yet enabled in our CI so not blocking it yet. |
|
Please update Mbed CLI 2 command line to match with 3.6.0 future release |
rajkan01
force-pushed
the
feature-cmake
branch
2 times, most recently
from
1e91412 to
a1fa0e0
Compare
rajkan01
force-pushed
the
feature-cmake
branch
from
a1fa0e0 to
d25f6f9
Compare
rajkan01
force-pushed
the
feature-cmake
branch
from
d25f6f9 to
890f819
Compare
|
@rajkan01 Ready to be merged now? |
Yes this PR is good to go and necessary keyword support added in latest mbed-tools release |
hugueskamba
requested changes
Dec 16, 2020
hugueskamba
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hugueskamba @0xc0170