Skip to content

CMake: Add the validation for supported application profile #13856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2020
Merged

CMake: Add the validation for supported application profile #13856

merged 2 commits into from
Nov 6, 2020

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Nov 4, 2020

Summary of changes

Added new mbed_check_if_application_profile_supported function to check supported profile based on target link libraries against target supported_application_profiles

Impact of changes

Migration actions required

Documentation

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170 @hugueskamba

hugueskamba
hugueskamba reviewed Nov 4, 2020
View reviewed changes
hugueskamba
hugueskamba reviewed Nov 4, 2020
View reviewed changes
@rajkan01 rajkan01 force-pushed the feature-cmake-baremetal-check branch 2 times, most recently from 8eb7916 to d740b0f Compare November 4, 2020 11:23
hugueskamba
hugueskamba reviewed Nov 4, 2020
View reviewed changes
@rajkan01 rajkan01 requested a review from hugueskamba November 4, 2020 11:34
@rajkan01 rajkan01 force-pushed the feature-cmake-baremetal-check branch from 8f785a2 to 74071ab Compare November 4, 2020 12:42
hugueskamba
hugueskamba previously approved these changes Nov 4, 2020
View reviewed changes
0xc0170
0xc0170 previously approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is breaking so examples will need to be updated

@rajkan01
Copy link
Contributor Author

rajkan01 commented Nov 4, 2020 •
edited
Loading

This is breaking so examples will need to be updated

I am doing changes for all the examples

@rajkan01
Copy link
Contributor Author

rajkan01 commented Nov 4, 2020 •
edited
Loading

Changes updated in the below examples and raised the PR, please review

ARMmbed/mbed-os-example-blinky-baremetal#46
ARMmbed/mbed-os-example-blinky#246
ARMmbed/mbed-os-example-lorawan#201
ARMmbed/mbed-os-example-cellular#204
ARMmbed/mbed-os-example-kvstore#59
ARMmbed/mbed-os-example-nfc#87
ARMmbed/mbed-os-example-sockets#165
ARMmbed/mbed-os-example-mbed-crypto#80
ARMmbed/mbed-os-example-devicekey#61
ARMmbed/mbed-os-example-ble#338

@rajkan01 rajkan01 force-pushed the feature-cmake-baremetal-check branch from 74071ab to 0d19bd3 Compare November 4, 2020 20:27
@mergify mergify bot dismissed stale reviews from hugueskamba and 0xc0170 November 4, 2020 20:27

Pull request has been modified.

0xc0170
0xc0170 previously approved these changes Nov 5, 2020
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 5, 2020

Waiting for all examples to be merged.

@0xc0170 0xc0170 mentioned this pull request Nov 5, 2020
Merged
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 5, 2020

ARMmbed/mbed-os-example-blinky-baremetal#46

This one should not be part of this PR, feature-cmake is already updated, fine for this PR

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 5, 2020

Waiting for the last PR ARMmbed/mbed-os-example-blinky#246. Once merged, I'll start CI here.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 5, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Nov 5, 2020
@mbed-ci
Copy link

mbed-ci commented Nov 5, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ❌
jenkins-ci/mbed-os-ci_cmake-example-ARM ❌

@rajkan01 rajkan01 force-pushed the feature-cmake-baremetal-check branch from 0d19bd3 to 837d977 Compare November 5, 2020 19:26
@mergify mergify bot dismissed 0xc0170’s stale review November 5, 2020 19:27

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 6, 2020

CI restarted

@mergify mergify bot added needs: work and removed needs: CI labels Nov 6, 2020
@mbed-ci
Copy link

mbed-ci commented Nov 6, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ❌
jenkins-ci/mbed-os-ci_cmake-example-ARM ❌

@mbed-ci
Copy link

mbed-ci commented Nov 6, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 4 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ❌
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ❌

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 6, 2020

Blinky passed this time, but looks like still there is a problem with other examples, I am investigating

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 6, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 6, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 5 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ❌

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 6, 2020

CI restarted

@rajkan01 rajkan01 force-pushed the feature-cmake-baremetal-check branch from 5185019 to 8bf0d1a Compare November 6, 2020 15:56
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 6, 2020

CI restarted again

0xc0170
0xc0170 previously approved these changes Nov 6, 2020
View reviewed changes
@rajkan01 rajkan01 force-pushed the feature-cmake-baremetal-check branch from 8bf0d1a to 909ed07 Compare November 6, 2020 15:59
@mergify mergify bot dismissed 0xc0170’s stale review November 6, 2020 16:00

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 6, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Nov 6, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 7 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ❌
jenkins-ci/mbed-os-ci_cmake-example-ARM ❌

@mbed-ci
Copy link

mbed-ci commented Nov 6, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 8 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️

@hugueskamba hugueskamba merged commit 73a9c03 into ARMmbed:feature-cmake Nov 6, 2020
hugueskamba pushed a commit that referenced this pull request Nov 6, 2020
@rajkan01 @hugueskamba
CMake: Validate selected application profile (#13856)
073ae1d 
Check if the selected application profile is supported by the selected Mbed Target
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugueskamba hugueskamba hugueskamba approved these changes

@0xc0170 0xc0170 0xc0170 left review comments

Assignees
No one assigned
Labels
release-version: feature branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rajkan01 @0xc0170 @mbed-ci @hugueskamba