Skip to content

Updating SPIFBlockDevice to latest #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2018
Merged

Conversation

offirko
Copy link
Contributor

@offirko offirko commented Aug 22, 2018

No description provided.

@offirko offirko requested a review from geky August 22, 2018 12:58
@offirko offirko merged commit 2e0ceed into master Aug 22, 2018
@cmonr
Copy link
Contributor

cmonr commented Aug 23, 2018

@offirko @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-test

This example is tested against every Mbed OS PR to make sure regressions do not appear.

However, this PR does not work with ARM and IAR compilers, and is about to be actively blocking the 5.9.6 PR once it's created.
Reference:

Please revert this PR ASAP so that the Mbed OS repo can continue CI testing.

geky added a commit that referenced this pull request Aug 23, 2018
Revert "Merge pull request #6 from ARMmbed/offir-blockdevice-example"
@offirko
Copy link
Contributor Author

offirko commented Aug 23, 2018

@cmonr - sorry for this. I used a UINT64_MAX macro that wasnt defined in ARM build.
@geky - thanks for reverting.
I fixed the problem and have a new PR for mbed-os-exampe-blockdevice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants