Skip to content

Revert "Merge pull request #6 from ARMmbed/offir-blockdevice-example" #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2018
Merged

Conversation

cmonr
Copy link
Contributor

@cmonr cmonr commented Aug 23, 2018

This reverts commit 2e0ceed, reversing
changes made to aad5284.

Referenced PR does not work when compiled with IAR and ARM compilers.
Blocking Mbed OS PRs in CI.

This reverts commit 2e0ceed, reversing
changes made to aad5284.

Referenced PR does not work when compiled with IAR and ARM compilers.
Blocking Mbed OS PRs in CI.
@cmonr
Copy link
Contributor Author

cmonr commented Aug 23, 2018

Welp, that confirms that @ARMmbed/mbed-os-maintainers don't have merge access to master.

@cmonr cmonr closed this Aug 23, 2018
@geky geky reopened this Aug 23, 2018
@geky geky merged commit c930725 into ARMmbed:master Aug 23, 2018
@geky
Copy link
Contributor

geky commented Aug 23, 2018

Related pr: #6
Reverted

Interestingly, @ARMmbed/mbed-os-maintainers is in the list of "write access" but master is protected, and that is a separate list. You guys should be added now.

Actually I'm a bit surprised you all don't have access as "org administrators". If this is how examples are organized, that may be worth investigating for the future. I think checking for access to all examples may be a bit hard to keep up with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants