This repository was archived by the owner on Apr 24, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 30, 2017
peknis01
reviewed
Jul 4, 2017
README.md
Outdated
@@ -171,24 +172,26 @@ With Thread, you can change the operating mode of the client from the default ro | |||
|
|||
#### Supported boards | |||
|
|||
* UBLOX_EVK_ODIN_W2. Check instructions for compilation [here](#compile-configuration-for-odin-wifi). | |||
* UBLOX_EVK_ODIN_W2. Check instructions for compilation [here](#compile-configuration-for-odin-and-realtek-wifi). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read the instructions for compilation. And the same for the other Realtek case.
peknis01
suggested changes
Jul 4, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just cosmetics, but the links with [here] are not the preferred way.
rebuild |
d5e15b2
to
4f41659
Compare
Enable REALTEK_RTL8195AM WiFi.
Update to the options line and a pre-defined configuration for REALTEK WiFi (new file; wifi_realtek_v4.json, based on wifi_esp8266_v4.json).
Plus in addition some common updates as well (links to boards that is). Small clarifications to the WiFi activation (usage of network interface param).
Fixes based on Pekka's comments on how to advice on reading the compilation instructions.
The name of the WIFI should follow the actual class name, this aligns the example code as well to match the change done in easy-connect. Adding NANOSTACK to features as well - this enables the code to compile even with the .mbedignore and now it also works again (there were issues prior that ethernet would not work, if nanostack was included). This should remove the need to have the .mbedignore files now.
The configs JSON file was still following the old naming convention, changing that as well.
Remove the known issues, they were all fixed already. Insert a table of supported boards/network connectivity, easier to read. Now, once we insert the "NANOSTACK" feature to the `*.json`s, we do not need the extra compilation instructions either.
4f41659
to
c14566e
Compare
Rebased and force pushed. |
Handled as part of #327 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable REALTEK_RTL8195AM WiFi.