Skip to content
This repository was archived by the owner on Apr 24, 2019. It is now read-only.

Support for STM Radio Expansion Boards #327

Merged
merged 1 commit into from
Nov 24, 2017
Merged

Support for STM Radio Expansion Boards #327

merged 1 commit into from
Nov 24, 2017

Conversation

betzw
Copy link
Contributor

@betzw betzw commented Nov 3, 2017

Status

PROPOSAL

Migrations

NO

Related PRs

#323

@betzw betzw mentioned this pull request Nov 3, 2017
Closed
@betzw betzw force-pushed the betzw_x_nucleo_wb branch 10 times, most recently from 7dd5137 to c45011a Compare November 6, 2017 09:23
@teetak01
Copy link
Contributor

teetak01 commented Nov 9, 2017

@betzw this PR might simplify this ARMmbed/wifi-x-nucleo-idw01m1#6

Having even more .mbedignore files makes the UX pretty bad.

@betzw
Copy link
Contributor Author

betzw commented Nov 9, 2017

Could you pls. synchronize on this within ARM and especially with @JanneKiiskila.
As far as I understand the trade-off is between smaller/correcter builds versus user experience.
I personally would prefer smaller builds - i.e. the old school approach where the developer should understand what he is doing - but not everybody might agree on this 😞

@betzw betzw force-pushed the betzw_x_nucleo_wb branch 3 times, most recently from 5f8598b to 81dc944 Compare November 10, 2017 16:04
@betzw
Copy link
Contributor Author

betzw commented Nov 13, 2017

Btw, it might be worthwhile to first merge PR #52, adapt the link to easy-connect in this PR and merge it only then.

@betzw betzw force-pushed the betzw_x_nucleo_wb branch from 81dc944 to 9a43bca Compare November 14, 2017 14:32
@betzw
Copy link
Contributor Author

betzw commented Nov 14, 2017

Ok I have updated easy-connect.lib!
@teetak01, @JanneKiiskila, it would be great if we could merge this PR asap. Pls. let me know.

@JanneKiiskila
Copy link
Contributor

Needs re-basing, tests are now failing on the README.md conflict.

@betzw
Copy link
Contributor Author

betzw commented Nov 14, 2017 •
edited
Loading

The network-interface as described in README.md just talks about WIFI rather than WIFI_ESP8266, WIFI_ODIN ecc. as expected by easy-connect.
Is this intentional?

@JanneKiiskila
Copy link
Contributor

That's not right, should be fixed.

@betzw
Copy link
Contributor Author

betzw commented Nov 14, 2017

Re-base done (and README.md corrected with respect to network-interface & WIFI).

@betzw betzw force-pushed the betzw_x_nucleo_wb branch 2 times, most recently from 820ee34 to 630f6c3 Compare November 15, 2017 14:50
This was referenced Nov 16, 2017
Closed
Closed
@teetak01
Copy link
Contributor

teetak01 commented Nov 16, 2017 •
edited
Loading

@JammuKekkonen please check if you are happy with this. Can probably be merged soon after.

@betzw
Copy link
Contributor Author

betzw commented Nov 17, 2017

bump @JanneKiiskila, @JammuKekkonen, @teetak01

@betzw
Copy link
Contributor Author

betzw commented Nov 21, 2017

bump @screamerbg

@betzw betzw force-pushed the betzw_x_nucleo_wb branch 3 times, most recently from a43bc5e to e46fe67 Compare November 23, 2017 15:19
@betzw betzw force-pushed the betzw_x_nucleo_wb branch from e46fe67 to 9861988 Compare November 23, 2017 15:24
@betzw
Copy link
Contributor Author

betzw commented Nov 23, 2017

@SeppoTakalo, not sure why this is stuck since a week now?

@teetak01
Copy link
Contributor

Verified via seperate test-PR #336

@teetak01 teetak01 merged commit 1ee3168 into ARMmbed:master Nov 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@teetak01 teetak01 teetak01 approved these changes

@JammuKekkonen JammuKekkonen Awaiting requested review from JammuKekkonen

@JanneKiiskila JanneKiiskila Awaiting requested review from JanneKiiskila

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@betzw @teetak01 @JanneKiiskila