IOTCLT-1737: use abstracted button names #290
Conversation
|
Nucleo F429_ZI fails. You could do test runs by running |
main.cpp
Outdated
| #endif | ||
|
|
||
| // Use the counter button handler to send an update of endpoint resource values | ||
| // to connector every 15 seconds periodically. | ||
| timer.attach(this, &InteractionProvider::counter_button_handler, 15.0); |
There was a problem hiding this comment.
If we do it this way, with boards having button -> the counter will be updated WITH counter + timer.
I was thinking of a separate counter resource and separate timer resource (lwm2m resource).
There was a problem hiding this comment.
Ah, I see. Should not be a big hurdle to add that separate resource after the main change is actually working.
| @@ -0,0 +1,22 @@ | |||
| { | |||
There was a problem hiding this comment.
I don't think Odin needs a separate ethernet config, it can re-use the generic eth config?
There was a problem hiding this comment.
the generic ethernet config has the button item enabled, and I tried to follow suit with the other board-specific deviations in the set of configurations.
| @@ -0,0 +1,22 @@ | |||
| { | |||
There was a problem hiding this comment.
Same here, odin can re-use the generic eth v6 json.
|
There's one thing still; see - mbed-os-example-client/main.cpp Line 289 in 0b81722 It's still referrring to K64F, it should refer to |
|
ARMmbed/mbed-os#4951 on-going to get the BUTTON1 defined to Ublox Odin. However, on my 1st trials it looked like the buttons in UBLOX do not work. |
|
What is status of this PR? |
|
We really need to get this in. Hexiwear is now failing spectacularly, because it's actually looking like "TARGET_K64F". Which I really do not understand, as it's Hexiwear, NOT K64F. https://github.com/ARMmbed/mbed-os/blob/master/targets/targets.json#L660 I think that is a bug, personally. Hexiwear is imposing to be a K64F, which it isn't. It shares the same MCU etc, but for example buttons are different. |
…ed the unregistration feature.
JuhaYlipekkala
force-pushed
the
button-abstraction
branch
from
982b185 to
955c2ac
Compare
|
I rebased the branch to latest from master, hopefully nothing major was broken in the process. |
Status
NOT READY
Migrations
NO
Description
Use abstracted button names and forget K64F-specific code. Refactored interaction functionality and ticker code to a separate class. Marked as not ready since this is just one possible approach to the issue and could be unnecessary.
Related PR
#289