UBLOX_EVK_ODIN_W2- add BUTTON1/2 definitions #4951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UBLOX_ODIN_EVK_W2 is missing the abstract button definitions originally introduced with PR ARMmbed#4249. Fix two tab to spaces issues on the go as well.
|
Fixes issue #4880. |
|
/morph test |
1 similar comment
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
|
Seems to be failing in something completely irrelevant, are your CI tests working? Doesn't look so. |
|
/morph test |
|
There was an IAR build issue which is fixed #4879 |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UBLOX_ODIN_EVK_W2 is missing the abstract button definitions originally
introduced with PR #4249.
Fix two tab to spaces issues on the go as well.
Description
Fix abstract buttons for UBLOX_EVK_ODIN_W2.
Status
READY
Migrations
NO
Related PRs
Todos
Mbed OS generic documentation for board porting would have to list the abstract button definition as a requirement.
Deploy notes
N/A
Steps to test or reproduce
Compile a test app which used BUTTON1 or BUTTON2.