Updating radio driver pointer and few logic updates for robustness #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hasnainvirk
commented
Jun 28, 2018
hasnainvirk
commented
- Radio driver now points to ARMmbed/mbed-semtech-lora-rf-drivers@5532d9d
- Core logic is updated to retry after 3 seconds if WOULD_BLOCK happens
- COMMON_PAL checks from the trace supporting logic is removed.
- A warning is rectified
added 4 commits
June 28, 2018 13:00
A warning was being generated that a float is being converted to a double. To mediate that we make sure that value stored is a float.
Driver library points to ARMmbed/mbed-semtech-lora-rf-drivers@5532d9d
As of 5.9, mbed trace is always present. We need now to check if the tracing was enabled in the app config. If not, setup_trace() does nothing.
If the stack is busy (could be because of automatic uplink and fpending bit being set etc), send() will return WOULD_BLOCK. We now enqueue a TX again after 3 seconds if WOULD_BLOCK happens. UPLINK_REQUIRED event in case of disabled automated uplinks, was not being handled. We handle it now and enqueue a transmission.
|
@kjbracey-arm @AnttiKauppila @kimlep01 Please review. |
Removing COMMON_PAL reference from the doc.
Using EU868 as the region identifier by default and hence giving away the use of an identification number.
kjbracey
approved these changes
Jun 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.