-
Notifications
You must be signed in to change notification settings - Fork 3k
LoRaWAN: Refactoring LoRaRadio::receive(uint32_t) API #7335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
receive(uint32_t) API in the LoRaRadio class (base class for the radio drivers) should not take any argument as we decided to take hardware timers for RX timeout interrupts instead of software timers. It is being refactored to receive(void). This is an API change, but as it is not an application interface, we will not put a deprecation notice. Only user of this API is our stack (LoRaPHY layer) which has been updated accordingly. Actual driver comes out of the tree and a PR is open there to update the drivers: ARMmbed/mbed-semtech-lora-rf-drivers#22 In addition to this an internal API belonging to LoRaPHY class is refactored. set_rx_window(parameters) is refactored to handle_receive(void) which is more consistent with handle_send().
@kjbracey-arm @cmonr @AnttiKauppila @0xc0170 Please review. |
/morph build |
Build : FAILUREBuild number : 2459 |
@0xc0170 Needs CI here. The remedy in the application code which resulted in failure of the build is in. |
👍 /morph build |
Build : SUCCESSBuild number : 2472 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2102 |
Test : SUCCESSBuild number : 2249 |
Description
receive(uint32_t) API in the LoRaRadio class (base class for the radio drivers) should
not take any argument as we decided to take hardware timers for RX timeout interrupts
instead of software timers. It is being refactored to receive(void).
This is an API change, but as it is not an application interface, we will not put a
deprecation notice. Only user of this API is our stack (LoRaPHY layer) which has been updated
accordingly.
Actual driver comes out of the tree and a PR is open there to update the drivers:
ARMmbed/mbed-semtech-lora-rf-drivers#22
In addition to this an internal API belonging to LoRaPHY class is refactored.
set_rx_window(parameters) is refactored to handle_receive(void) which is more consistent with
handle_send().
Pull request type
Target
Mbed OS 5.10