Skip to content

LoRaWAN: Refactoring LoRaRadio::receive(uint32_t) API #7335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2018

Conversation

hasnainvirk
Copy link
Contributor

Description

receive(uint32_t) API in the LoRaRadio class (base class for the radio drivers) should
not take any argument as we decided to take hardware timers for RX timeout interrupts
instead of software timers. It is being refactored to receive(void).
This is an API change, but as it is not an application interface, we will not put a
deprecation notice. Only user of this API is our stack (LoRaPHY layer) which has been updated
accordingly.
Actual driver comes out of the tree and a PR is open there to update the drivers:
ARMmbed/mbed-semtech-lora-rf-drivers#22

In addition to this an internal API belonging to LoRaPHY class is refactored.
set_rx_window(parameters) is refactored to handle_receive(void) which is more consistent with
handle_send().

Pull request type

[ ] Fix
[X] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Target

Mbed OS 5.10

receive(uint32_t) API in the LoRaRadio class (base class for the radio drivers) should
not take any argument as we decided to take hardware timers for RX timeout interrupts
instead of software timers. It is being refactored to receive(void).
This is an API change, but as it is not an application interface, we will not put a
deprecation notice. Only user of this API is our stack (LoRaPHY layer) which has been updated
accordingly.
Actual driver comes out of the tree and a PR is open there to update the drivers:
ARMmbed/mbed-semtech-lora-rf-drivers#22

In addition to this an internal API belonging to LoRaPHY class is refactored.
set_rx_window(parameters) is refactored to handle_receive(void) which is more consistent with
handle_send().
@hasnainvirk
Copy link
Contributor Author

@kjbracey-arm @cmonr @AnttiKauppila @0xc0170 Please review.

@0xc0170 0xc0170 requested a review from a team June 26, 2018 14:40
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 27, 2018

/morph build

@hasnainvirk hasnainvirk changed the title Refactoring LoRaRadio::receive(uint32_t) API LoRaWAN: Refactoring LoRaRadio::receive(uint32_t) API Jun 27, 2018
@mbed-ci
Copy link

mbed-ci commented Jun 27, 2018

Build : FAILURE

Build number : 2459
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7335/

@hasnainvirk
Copy link
Contributor Author

@0xc0170 Needs CI here. The remedy in the application code which resulted in failure of the build is in.
ARMmbed/mbed-os-example-lorawan#85

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 28, 2018

@0xc0170 Needs CI here. The remedy in the application code which resulted in failure of the build is in.
ARMmbed/mbed-os-example-lorawan#85

👍

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 28, 2018

Build : SUCCESS

Build number : 2472
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7335/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 28, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 28, 2018

@cmonr cmonr merged commit d06826b into ARMmbed:master Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants